Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athenaeum #165

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Athenaeum #165

merged 5 commits into from
Oct 4, 2024

Conversation

yukitya-1811
Copy link
Contributor

Description

Add event page for Athenaeum including speakers, events and timeline

Fixes # (issue)

Dependencies

List any dependencies that are required for this change.

Type of Change

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an x in the boxes that apply

  • Test A
  • Test B

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@imApoorva36 imApoorva36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even for other resources, ig if event hasn't happenned, dont display the button

Also, for session link, the teams link for say 3rd Octobe's session is still there, better to remove it after the event?

corpus/templates/athenaeum/home.html Outdated Show resolved Hide resolved
@nishant-nayak nishant-nayak temporarily deployed to athenaeum - corpus-dev PR #165 October 4, 2024 13:36 — with Render Destroyed
@imApoorva36
Copy link
Contributor

LGTM

@imApoorva36 imApoorva36 merged commit e2143fe into main Oct 4, 2024
1 check passed
@imApoorva36 imApoorva36 deleted the athenaeum branch October 4, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants