Fix google map offsets in china #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng =( The plugin changes coordinates, but the change is not applied
…ap tiles (except Google maps)
lint: * `let` is not in es5 * 'HK_LENGTH' is assigned a value but never used * 'original' is defined but never used style: * == vs === * Mixed spaces and tabs * fix indents, missed/extra/trailing spaces, missed semi
divide PRCoords into 2 distinct functions: * plugin.fixChinaOffset.isInGoogle * plugin.fixChinaOffset.gcjObfs added stub for old fix-googlemap-china-offset plugin
|
It it possible to extend L.GridLayer via leaflet api (instead of monkey-patching)? |
johnd0e
requested changes
Jan 18, 2019
johnd0e
reviewed
Jan 18, 2019
I don't know, it's the only way I can do( |
Co-Authored-By: modos189 <[email protected]>
Co-Authored-By: modos189 <[email protected]>
Co-Authored-By: modos189 <[email protected]>
|
https://leafletjs.com/examples/extending/extending-1-classes.html |
|
As we named the plugin
|
|
P.S. See #72 |
added 3 commits
January 19, 2019 15:57
* Sources refactored to be closer to upstream https://github.com/Artoria2e5/PRCoords * Baidu support * Clarify comment about usage
added 5 commits
January 24, 2019 17:42
do not touch L.GridLayer extend L.TileLayer and L.GridLayer.GoogleMutant
johnd0e
pushed a commit
to johnd0e/ingress-intel-total-conversion
that referenced
this pull request
Jan 28, 2019
Sample China map to illustrate IITC-CE#68. Currently we can get road map with slightly different look. It is not straightforward, as there are not much info in official API [docs](https://lbs.amap.com/api/javascript-api/example/). I've played with some parameters, and you can see result after uncommenting corresponding lines. Some of the variants allow language change. P.S. Different map themes could be seen here: https://lbs.amap.com/api/javascript-api/example/personalized-map/set-theme-style. Unfortunately I've failed to figure out if it's possible to implement it in the plugin.
In current state it doesn't function. Maybe someone reimplement it in future. More info here: #64.
johnd0e
pushed a commit
to johnd0e/ingress-intel-total-conversion
that referenced
this pull request
Feb 8, 2019
Sample China map to illustrate IITC-CE#68. Currently we can get road map with slightly different look. It is not straightforward, as there are not much info in official API [docs](https://lbs.amap.com/api/javascript-api/example/). I've played with some parameters, and you can see result after uncommenting corresponding lines. Some of the variants allow language change. P.S. Different map themes could be seen here: https://lbs.amap.com/api/javascript-api/example/personalized-map/set-theme-style. Unfortunately I've failed to figure out if it's possible to implement it in the plugin.
|
New feature idea: instead of hardcoding polygon we could allow import from draw-tools or geojson: http://geojson.io/#id=gist:johnd0e/2d61d1fec27da8fc09428fe82b84c3e6&map=4/37.85/104.06 |
johnd0e
pushed a commit
to johnd0e/ingress-intel-total-conversion
that referenced
this pull request
Feb 25, 2019
johnd0e
pushed a commit
to johnd0e/ingress-intel-total-conversion
that referenced
this pull request
Feb 25, 2019
johnd0e
pushed a commit
to johnd0e/ingress-intel-total-conversion
that referenced
this pull request
Feb 28, 2019
Sample China map to illustrate IITC-CE#68. Currently we can get road map with slightly different look. It is not straightforward, as there are not much info in official API [docs](https://lbs.amap.com/api/javascript-api/example/). I've played with some parameters, and you can see result after uncommenting corresponding lines. Some of the variants allow language change. P.S. Different map themes could be seen here: https://lbs.amap.com/api/javascript-api/example/personalized-map/set-theme-style. Unfortunately I've failed to figure out if it's possible to implement it in the plugin.
added 2 commits
February 28, 2019 15:00
update to 'Fix google map offsets in china'
|
To be Squash and merge |
johnd0e
pushed a commit
to johnd0e/ingress-intel-total-conversion
that referenced
this pull request
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this plugin fixes coordinate correction for some maps in China. #64
It is also now possible to enable correction not only for Google maps.