Constructron selection tool doesn't respect all to_be_upgraded entities#291
Open
wolfcomp wants to merge 1 commit intoILLISIS:mainfrom
Open
Constructron selection tool doesn't respect all to_be_upgraded entities#291wolfcomp wants to merge 1 commit intoILLISIS:mainfrom
to_be_upgraded entities#291wolfcomp wants to merge 1 commit intoILLISIS:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Digging through the code and what is being returned I have found that not all entities to be upgraded has a
item-request-proxyattached to it.This is being processed here https://github.com/ILLISIS/Constructron-Continued/blob/main/script/entity_processor.lua#L370-L372
Digging through the Factorio API there is a specific
to_be_upgradedfunction that can be called for an entity to check if it is marked for an upgrade.Things not checked for currently with this PR
get_upgrade_target()to get the entity prototype out when checking what item to request for if its an entity to be upgradedUpgrade jobsis not selected