Rendering task updates #11

seuribe · 2018-06-06T12:22:15Z

Several small and medium changes to optimize the rendering. The most important one is the use of a pool for Color3f arrays, which reduces considerably garbage collection and allows it to run without problems with less memory.
Other changes include some refactoring / reorganization of the code, and a reduction in the amount of operations needed for some rendering tasks.

…code

…u,v) position in the viewing plane

…ns for the internal color buffer index

- moved color buffer creation & pooling to the new class

- moved the statistics printing to a separate method

… size, instead of the pool instance

- rename variables - calculate the square root of the normal length only if needed - avoid recalculating view direction, take instead the negated ray direction

porst17

Please adjust the commit messages of your commits (e.g. by interactive rebase + force push). The general rule of thumb in most git projects (including the Linux kernel) is to split the commit messages in two parts separated by a blank line:

Short description (Subject line)

Long description or additional information

A properly formed git commit subject line should always be able to complete the following sentence:
If applied, this commit will <your subject line here>

It starts with a capital letter and has no period at the end.

It never starts with a dash -

You can find more details here.

By pushing synchronization down to each individual bucket instad of the pool class, the granularity of locking should be increased, reducing the chances of threads being blocked.

Separating shading logic makes de code more readable, and opens the doors to later implementing multiple shading algorithms.

The ray already contains the viewing direction, so it does not need to be recalculated. By changing which parameters are passed to the shade function, it's possible to avoid some vector operations.

…/jsurf into rendering_task_updates

This will remove the need for most other instance variables, and allow to remove parameters from some functions

When vOld == 0, the CSP will have only null pointers, which are never used. When vOld == the old v, then it will just overwrite the previous CSP set for v. This does not happen when the hashmap is cleared, but doing so prevents the reuse of the CS and CSG for different pixels in the same column.

This removes the responsibilities of the rendering methods, as how the CSP is stored can be considered a different concern. Also, this change opens the doors to changing how the CSPs are cached, as a hashmap might not be the most efficient solution.

…ction

Remove unused and commented out code, replace .* imports with just the needed ones.

A small optimization to avoid creating a new vector and two vector class function calls every time the similarity of colors is evaluated.

Avoid doing too many conditions inside the tightest loop. Instead, pre-calculate always the corner rays and then skip them when iterating over the SamplingPoints.

…ng function

seuribe added 11 commits June 6, 2018 09:12

- separated rendering modes in functions, removed some commented out …

7935e4b

…code

- replaced multiplications with additions in the calculation of the (…

d26e9e8

…u,v) position in the viewing plane

- replaced multiplications with increments, additions and substractio…

6a29d4f

…ns for the internal color buffer index

- prepared the code for using color buffer pooling

1afa350

- created a new Color buffer pool class

819456c

- moved color buffer creation & pooling to the new class

-added documentation

a202b46

- moved the statistics printing to a separate method

- pushed down the synchronization to the bucket for a specific buffer…

8db021b

… size, instead of the pool instance

- cleanup: moved shading code to a different class

be1e429

- rename variables and made code slightly more readable

e43760a

- remove unneeded for loop

fae12e8

Some changes in the shade function

8cec89a

- rename variables - calculate the square root of the normal length only if needed - avoid recalculating view direction, take instead the negated ray direction

seuribe closed this Jun 6, 2018

seuribe reopened this Jun 6, 2018

seuribe requested a review from porst17 June 6, 2018 12:22

porst17 requested changes Jun 7, 2018

View reviewed changes

seuribe added 15 commits June 7, 2018 13:22

Separate concerns of rendering into different methods

5a51f0a

Replace multiplications with additions

3b7253a

Replace mutliplications with simpler operations

447a51c

Prepare the code for using color buffer pooling

11c0e86

Implement Color buffer pooling

d4f34de

Improved documentation of the code

643c116

Change the way color buffer pools are synchronized

075ec24

By pushing synchronization down to each individual bucket instad of the pool class, the granularity of locking should be increased, reducing the chances of threads being blocked.

Move shading code to its own class

f758442

Separating shading logic makes de code more readable, and opens the doors to later implementing multiple shading algorithms.

Make the code more readable

39da69b

Remove unneeded for loop

340eaa4

Avoid recalculating the view direction and improve readability

7ede634

The ray already contains the viewing direction, so it does not need to be recalculated. By changing which parameters are passed to the shade function, it's possible to avoid some vector operations.

Merge branch 'rendering_task_updates' of https://github.com/IMAGINARY…

3b6f7d1

…/jsurf into rendering_task_updates

Avoid recalculating internal width and height

bf00999

Move pixel-stepping information to a new class

3b834a8

De-duplicate PixelStep creation

73a22aa

seuribe added 27 commits June 8, 2018 20:55

Move u and v variables inside the PixelStep instance

ba49dee

Move image dimensions into the PixelStep

dbcf1bf

Make PixelStep an instance variable

fa674df

This will remove the need for most other instance variables, and allow to remove parameters from some functions

Restore correct pixel displacement when rendering without aliasing

28c0513

Make the CSP hashmap an instance variable

6aa5067

Move logic of choosing which render method to use into call method

c2f30c9

Move inner classes to top of file

78f1339

Move CSP creation to a new class

9ff7187

This removes the responsibilities of the rendering methods, as how the CSP is stored can be considered a different concern. Also, this change opens the doors to changing how the CSPs are cached, as a hashmap might not be the most efficient solution.

Correct names of functions

a156efc

Remove the internal color buffer index control from the rendering fun…

3ff425c

…ction

Move pixel render strategy to new method(s)

eb7efdf

Move pixel render strategies to its own class

35a6eec

Create new class for doing the Polynomial Tracing and returning the hit

b4287cb

Move remaining shading code into the Pixel rendering classes

0c5e8c5

Move Pixel render strategy classes to their own files

f112b62

Move ColumnSubstitutorPair and provider classes to their own files

ba1c889

Move PixelStep class to its own file

ce0031f

Clean up file

5f850fb

Remove unused and commented out code, replace .* imports with just the needed ones.

Move calculation of width and height into PixelStep

d3d4112

Remove dead code

d662817

Replace method access with final public fields in SamplingPoint

61c9193

Refactor threshold evaluating function

1f5375e

A small optimization to avoid creating a new vector and two vector class function calls every time the similarity of colors is evaluated.

Simplify super sampling code

3a94181

Avoid doing too many conditions inside the tightest loop. Instead, pre-calculate always the corner rays and then skip them when iterating over the SamplingPoints.

Avoid checking similarity of corner pixels when supersampling is forced

c4c23c6

Move all corner point related calculation outside of the super sampli…

2e8b2f8

…ng function

Change CSP Provider to use an array instead of a hashmap

b377d72

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rendering task updates #11

Rendering task updates #11

seuribe commented Jun 6, 2018

porst17 left a comment

Rendering task updates #11

Are you sure you want to change the base?

Rendering task updates #11

Conversation

seuribe commented Jun 6, 2018

porst17 left a comment

Choose a reason for hiding this comment