-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding documentation builds #15
Conversation
Nice! I really like the automated documentation approach. A few things: I think we agreed PRs should be created to merge to dev branch We might start making .md files in the docs directory to provide folks info on how to use the repo. For example add this to describe the build process for sphinx:
Do we want to create documentation on Github Pages and/or Confluence? Also, Matt Watwood has done this for Libera in Confluence so before we reinvent the wheel we might take a look at what was done. |
Here's an example of the markdown file for Libera, which is probably far more than we need, but may be a helpful template. |
This adds the basics to start building our docs and organizing the sphinx page structure.
Is this for external documentation? or internal? So, is this intended to replace confluence or the github wiki, or does it operate as more of a readthedocs type thing? |
I view this as documenting the code and a little less focused on all of the confluence stuff. I think since this is a public repo, the docs should be public as well. We can certainly push to readthedocs as well if we'd prefer that route instead of GitHub Pages, I'm indifferent.
Good catch! dev is unfortunately behind right now, but I can rebase and point to that once the merge-back PR is in. |
# Commit the changes and push to your remote repository | ||
git add my-file | ||
git commit | ||
git push -u origin my-cool-feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a great content to add to style guide. Or style guild could be included in this automated doc generator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I agree, I think the style guide should either go into the docs, or vice-versa the style guide point to the docs.
Sounds good to me! I'd like if we could define what kind of documentation we'd like to see (more templates, anyone?) but I think this looks good! Maybe we can require documentation as part of a PR, same as tests? |
b253925
into
IMAP-Science-Operations-Center:dev
Adding documentation builds
Change Summary
Overview
This adds sphinx documentation that can be built for easier exploration of API functionality. Based off of the workflow for this project, with an example of what this will look like when deployed: https://swxtrec.github.io/pymsis/
Future work:
New Dependencies
sphinx, pydata-sphinx-theme
New Files
Many under the
docs/
folder to start the basic structureUpdated Files
init.py
pyproject.toml
[doc]
group.Testing
Current testing is done by just building the docs on PR and uploading the artifact that can be downloaded and inspected. It would be good to post the deployed artifact somewhere for easier viewing, which we can automate via CircleCI. But that can come in follow-up PRs if people want.