Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #677

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

pre-commit-ci bot and others added 2 commits July 1, 2024 17:59
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)
- [github.com/astral-sh/ruff-pre-commit: v0.3.4 → v0.5.0](astral-sh/ruff-pre-commit@v0.3.4...v0.5.0)
- [github.com/codespell-project/codespell: v2.2.6 → v2.3.0](codespell-project/codespell@v2.2.6...v2.3.0)
@greglucas
Copy link
Collaborator

Two minor issues noted. I pushed an update for the spelling change.

@laspsandoval can you update the Ultra code how you'd prefer?
https://results.pre-commit.ci/run/github/654679818/1719856778.E535ULS6TqSko9Gbh0Xmdw
I don't know how you want to use that loop because you are doing filtering and grouping, so want to make sure you get it how you want it.

imap_processing/ultra/l1a/ultra_l1a.py:331:9: PLR1704 Redefining argument with the local name `apid`
    |
329 |         apids = grouped_data.keys()
330 | 
331 |     for apid in apids:
    |         ^^^^ PLR1704
332 |         if apid == ULTRA_EVENTS.apid[0]:
333 |             decom_ultra_dict = {
    |

@@ -21,7 +21,7 @@ productive environment that enriches the surrounding community.
We as members, contributors, and leaders pledge to make participation in our
community a harassment-free experience for everyone, regardless of age, body
size, visible or invisible disability, ethnicity, sex characteristics, gender
identity and expression, level of experience, education, socio-economic status,
identity and expression, level of experience, education, socioeconomic status,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love learning about grammar updates through automated Github robots 🤖

@greglucas
Copy link
Collaborator

@laspsandoval can you take a look at this? Let me know if you want me to fix the issue.

#677 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants