Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ultra Extended L1b Lookup tables #696

Merged

Conversation

laspsandoval
Copy link
Contributor

@laspsandoval laspsandoval commented Jul 22, 2024

Change Summary

Overview

Breaking up PR #686. This is just a way to use the lookup tables.

New Files

lookup_utils.py

  • Contains tools for lookup tables for l1b.

/lookup_tables (7 files)

  • These were provided by the Ultra team.

Testing

test_lookup_utils.py

  • Tests lookup_utils.py

@laspsandoval laspsandoval self-assigned this Jul 22, 2024
@laspsandoval laspsandoval changed the title Lookup tables Ultra Extended L1b Lookup tables Jul 22, 2024
@laspsandoval laspsandoval added Ins: Ultra Related to the IMAP-Ultra instrument Level: L1 Level 1 processing labels Jul 22, 2024
@laspsandoval laspsandoval requested review from greglucas, a team, sdhoyt and subagonsouth and removed request for a team July 22, 2024 15:10
@laspsandoval
Copy link
Contributor Author

@greglucas in the spirit of moving forward quickly could you approve if nothing else stands out?

Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Two naming nit picks noted.

imap_processing/tests/ultra/unit/test_lookup_utils.py Outdated Show resolved Hide resolved
imap_processing/ultra/l1b/lookup_utils.py Outdated Show resolved Hide resolved
@laspsandoval laspsandoval merged commit b9abcb3 into IMAP-Science-Operations-Center:dev Aug 5, 2024
17 checks passed
@laspsandoval laspsandoval deleted the lookup_tables branch August 5, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ins: Ultra Related to the IMAP-Ultra instrument Level: L1 Level 1 processing
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants