MNT/ENH: Add FLOAT and FILL options for spreadsheet dataType #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two new options to the handled data types, and also raises an error if we get a datatype that isn't handled. This is important because otherwise there will be a parameter added without a corresponding parameterType entry.
greglucas
force-pushed
the
xtce-float-fill
branch
2 times, most recently
from
c593f9f
to
955845d
Compare
greglucas
commented
Jul 26, 2024
There was a problem hiding this comment.
I went down the road of mocking/creating this spreadsheet in code, but it ended up being a lot more confusing in my opinion to follow what was being changed/updated. So this seemed reasonable to add a small-ish binary file for testing this routine for clarity's sake.
greglucas
force-pushed
the
xtce-float-fill
branch
from
955845d
to
d517443
Compare
Add a simple excel file with variable types we want to test and assert against a known XML file we have produced.
greglucas
force-pushed
the
xtce-float-fill
branch
from
d517443
to
0c65eb1
Compare
|
@tech3371, ping for review on this again. |
tech3371
approved these changes
Jul 30, 2024
| def test_generated_xml(excel_file, tmp_path): | ||
| """Make sure we are producing the expected contents within the XML file. | ||
|
|
||
| To produce a new expected output file the following command can be used. |
There was a problem hiding this comment.
Good to know! This makes me wonder, do we have readme for this cli tool?
There was a problem hiding this comment.
We have an issue to make this better! On my list...
#703
subagonsouth
approved these changes
Jul 30, 2024
greglucas
merged commit ba50882
into
IMAP-Science-Operations-Center:dev
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This adds two new options to the handled data types, and also raises an error if we get a datatype that isn't handled. This is important because otherwise there will be a parameter added without a corresponding parameterType entry.
Working from an SCID spreadsheet, I now get the following parameterTypes, when they were missing before.
closes #697