Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hi test data and fixture refactor #709

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Hi test data and fixture refactor #709

merged 2 commits into from
Jul 24, 2024

Conversation

subagonsouth
Copy link
Contributor

Change Summary

  • Moved Hi L0 test data into tests/hi/test_data/l0 directory
  • Refactored some Hi tests to better utilize test fixtures

Overview

This is a small change set consisting of some reorganization of Hi test data and an improvement in use of fixtures for determining paths to test data.

New Dependencies

None

New Files

None

Deleted Files

None

Updated Files

  • imap_processing/tests/conftest.py
    • Removed functions that are only used in Hi specific fixtures
    • Added fixture that returns the Path to the base tests directory
  • imap_processing/tests/hi/conftest.py
    • Moved in Hi specific functions
    • Added some fixtures for returning Paths to test directories
  • imap_processing/tests/hi/test_decom.py
    • Use new Path fixtures
  • imap_processing/tests/hi/test_hi_l1b.py
    • Use new Path fixtures
  • imap_processing/tests/hi/test_l1a.py
    • Use new Path fixtures

Testing

See above

Closes #543

@subagonsouth
Move common and hi fixtures into plugins directory
9e2859c 
Add pytest_plugins definition to root conftest.py
Refactor hi test_data structure
Add fixtures for hi test data
@subagonsouth
Refactor to match typical pytest usage of nested conftest.py files fo…
0e28869 
…r fixtures
@subagonsouth subagonsouth requested a review from a team July 23, 2024 21:03
@subagonsouth subagonsouth self-assigned this Jul 23, 2024
@subagonsouth subagonsouth requested review from bourque, sdhoyt and tech3371 and removed request for a team July 23, 2024 21:03
tech3371
tech3371 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@tech3371 tech3371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@subagonsouth subagonsouth merged commit a257b7e into IMAP-Science-Operations-Center:dev Jul 24, 2024
17 checks passed
@subagonsouth subagonsouth deleted the 543-propose-pytest-fixture-organization-scheme branch July 24, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tech3371 tech3371 tech3371 approved these changes

@bourque bourque Awaiting requested review from bourque bourque was automatically assigned from IMAP-Science-Operations-Center/sdc-random-1

@sdhoyt sdhoyt Awaiting requested review from sdhoyt sdhoyt was automatically assigned from IMAP-Science-Operations-Center/sdc-random-1

Assignees

@subagonsouth subagonsouth

Labels
None yet
Projects
IMAP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

propose pytest fixture organization scheme
2 participants
@subagonsouth @tech3371