SWAPI l2 Implementation - counts to rate #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech3371
added
Ins: SWAPI
tech3371
requested review from
bryan-harter,
maxinelasp,
anamanica,
greglucas and
subagonsouth
and removed request for
a team
greglucas
reviewed
Jul 26, 2024
imap_processing/swapi/l2/swapi_l2.py
Outdated
| t_bin time. t_bin is the exposure time per energy bin which is | ||
| obtained by dividing the time for one complete sweep | ||
| (12 s, coarse + fine sweep) by the total energy steps (72), | ||
| i.e., t_bin = 12/72 = 0.167 s. This will be constant. |
There was a problem hiding this comment.
Make this a global constant outside the function? TIME_PER_BIN = 12 / 72
Note that 12/72 is not equal to 0.167, it is 0.166666 repeating. Do you want to store 0.167 or 12/72?
There was a problem hiding this comment.
Their algorithm document says to use 0.167. That's why I used that. This comment was to give background understanding of where that value came from. I can ask SWAPI team this week.
subagonsouth
approved these changes
Jul 29, 2024
greglucas
approved these changes
Jul 29, 2024
tech3371
merged commit 00b70ad
into
IMAP-Science-Operations-Center:dev
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Process SWAPI L1 to L2. This PR will close this ticket: #706
New Files
Updated Files
Added L2 updates to these files
Testing