MNT: Change to a period separator for XTCE definitions #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the XTCE generator to produce a period between the packet name and the mnemonic name, which helps for subsequent parsing. Additionally, use that helpful fact to strip that leading packet name in the packet_file_to_datasets routine.
tech3371
approved these changes
Jul 31, 2024
greglucas
merged commit c75ad40
into
IMAP-Science-Operations-Center:dev
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This updates the XTCE generator to produce a period between the packet name and the mnemonic name, which helps for subsequent parsing.
Additionally, use that helpful fact to strip that leading packet name in the packet_file_to_datasets routine.
Testing
I did test this out manually by modifying an XTCE file to ensure that the stripping works as expected, but there aren't any other packet definitions with a packet name to make this easily testable yet. Maybe we'll update some of the packet definitions soon to exercise this.