Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ultra Extended L1b Front Coordinates #730

Merged
merged 9 commits into from
Aug 13, 2024
Merged

Ultra Extended L1b Front Coordinates #730

merged 9 commits into from
Aug 13, 2024

Conversation

laspsandoval
Copy link
Contributor

@laspsandoval laspsandoval commented Aug 5, 2024 •
edited
Loading

Change Summary

Overview

The position of the particle along the front of the sensor.

New Files

  • l1b_extended_config.py
    • place to store constants
  • ultra_l1b_extended.py
    • The position of the particle along the front of the sensor (xf, yf)
  • FM45_40P_Phi28p5_BeamCal_LinearScan_phi28.50_theta-0.00_Ultra_Image_Raw_Event_20240207T102746_withFSWcalcs.csv
    • Test data

Updated Files

  • conftest.py
    • path of test data
    • creation of event data
  • lookup_utils.py
    • added ability to lookup array

Testing

  • test_ultra_l1b_extended.py
    • test ultra_l1b_extended.py

laspsandoval
laspsandoval commented Aug 5, 2024
View reviewed changes
imap_processing/tests/ultra/unit/test_ultra_l1b_extended.py

d, yf = get_front_y_position(
de_dataset["START_TYPE"].data, df_filt.Yb.values.astype("float")
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: there is no test data for the value of d.

subagonsouth
subagonsouth approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. I pointed out a few nit picks in comments. Thanks for breaking these changes out!

imap_processing/ultra/l1b/ultra_l1b_extended.py Outdated Show resolved Hide resolved
imap_processing/ultra/l1b/ultra_l1b_extended.py Outdated Show resolved Hide resolved
imap_processing/ultra/l1b/l1b_extended_config.py Outdated Show resolved Hide resolved
@laspsandoval laspsandoval merged commit 9d7bd05 into IMAP-Science-Operations-Center:dev Aug 13, 2024
17 checks passed
@laspsandoval laspsandoval deleted the ultra_extended_l1b_front branch August 13, 2024 15:47
@bourque bourque added Ins: Ultra Related to the IMAP-Ultra instrument Level: L1 Level 1 processing labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subagonsouth subagonsouth subagonsouth approved these changes

@greglucas greglucas Awaiting requested review from greglucas

Assignees

@laspsandoval laspsandoval

Labels
Ins: Ultra Related to the IMAP-Ultra instrument Level: L1 Level 1 processing
Projects
No open projects
Release v0.5.x
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laspsandoval @subagonsouth @bourque