Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pulse Height Calculations #750

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Add Pulse Height Calculations #750

merged 4 commits into from
Aug 27, 2024

Conversation

laspsandoval
Copy link
Contributor

Change Summary

Overview

Adds calculations for PH for TOF and back positions.

Updated Files

  • ultra_l1b_extended.py
    • Calculate back xb, yb position and tof.
  • lookup_utils.py
    • Minor formatting.

Testing

test_ultra_l1b_extended.py

  • Test data for xb, yb position. No TOF test data available.

@laspsandoval laspsandoval self-assigned this Aug 14, 2024
@greglucas greglucas added Ins: Ultra Related to the IMAP-Ultra instrument Level: L1 Level 1 processing labels Aug 20, 2024
subagonsouth
subagonsouth approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a complex function! Looks like you have good test coverage for it. Couple of suggestions about using np.nonzero instead of np.where.

imap_processing/ultra/l1b/ultra_l1b_extended.py Outdated Show resolved Hide resolved
imap_processing/ultra/l1b/ultra_l1b_extended.py Outdated Show resolved Hide resolved
imap_processing/tests/ultra/unit/test_ultra_l1b_extended.py Outdated Show resolved Hide resolved
@laspsandoval laspsandoval merged commit 3e71692 into IMAP-Science-Operations-Center:dev Aug 27, 2024
17 checks passed
@laspsandoval laspsandoval deleted the ph_tof_and_back_positions branch August 27, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglucas greglucas greglucas left review comments

@subagonsouth subagonsouth subagonsouth approved these changes

@sdhoyt sdhoyt Awaiting requested review from sdhoyt

Assignees

@laspsandoval laspsandoval

Labels
Ins: Ultra Related to the IMAP-Ultra instrument Level: L1 Level 1 processing
Projects
IMAP
Status: Done
Release v0.5.x
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laspsandoval @greglucas @subagonsouth