Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated/Combined Lo XTCE #754

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

sdhoyt
Copy link
Contributor

@sdhoyt sdhoyt commented Aug 16, 2024

Change Summary

Overview

Updated the Lo XTCE using the new xtce generation script

New Files

  • lo_xtce.xml

Deleted Files

Deleted all other Lo XTCE files in lo/packet_definitions

Closes #753

@sdhoyt sdhoyt added Ins: Lo Related to the IMAP-Lo instrument Level: L0 Level 0 processing labels Aug 16, 2024
@sdhoyt sdhoyt self-assigned this Aug 16, 2024
@sdhoyt
Copy link
Contributor Author

sdhoyt commented Aug 16, 2024

It looks like the test_decom.py unit test needs to be updated for the different XTCE keys that are used in the new generation script. I'm looking into that now

Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you weren't ever using the previous XML files in the Lo tests? I didn't look in detail at the XML, but assume you've checked that you have all the needed apids from the previous packet definitions in the new file and know how to get that out of this consolidated definition?

@sdhoyt
Copy link
Contributor Author

sdhoyt commented Aug 16, 2024

I guess you weren't ever using the previous XML files in the Lo tests? I didn't look in detail at the XML, but assume you've checked that you have all the needed apids from the previous packet definitions in the new file and know how to get that out of this consolidated definition?

Correct, I wasn't using the XTCE in any of the Lo unit tests. I looked through the xml and everything looked good. My plan is when I do the decom validation I'll also validate that the XTCE is correct.

@sdhoyt sdhoyt merged commit f3b49d0 into IMAP-Science-Operations-Center:dev Aug 20, 2024
17 checks passed
@sdhoyt sdhoyt deleted the update-lo-xtce branch August 20, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ins: Lo Related to the IMAP-Lo instrument Level: L0 Level 0 processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regenerate Lo XTCE
2 participants