MNT: Add useful error message when packet to datasets fails #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subagonsouth
approved these changes
Aug 21, 2024
This occurs when there is a nested packet file definition with different variables for packets with the same apid. For example, with data spread across multiple packets and that definition being written into the XTCE logic.
greglucas
force-pushed
the
packet-to-dataset-warning
branch
from
fbb81da
to
be5cedd
Compare
|
Force-pushing a new commit trying to retrigger pre-commit since I couldn't see a button to just re-run that single failing job :( |
greglucas
merged commit 427cbf1
into
IMAP-Science-Operations-Center:dev
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This occurs when there is a nested packet file definition with different variables for packets with the same apid. For example, with data spread across multiple packets and that definition being written into the XTCE logic.
Implementing the suggestion from here:
#743 (comment)
@anamanica let me know if you think there is a better wording for this or if there is some other error message that would have helped in your debugging.