Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ultra l1b extended ssd #789

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Ultra l1b extended ssd #789

merged 4 commits into from
Sep 3, 2024

Conversation

laspsandoval
Copy link
Contributor

Change Summary

Overview

Added calculation of SSD back position and TOF offset (another part of Ultra l1b extended)

Updated Files

  • ultra_l1b_extended.py
    • Added calculation of SSD back position and TOF offset
  • test_ultra_l1b_extended.py
    • Test ultra_l1b_extended.py

Testing

  • test_ultra_l1b_extended.py
    • Test ultra_l1b_extended.py

@laspsandoval laspsandoval self-assigned this Aug 27, 2024
subagonsouth
subagonsouth approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I left a question and a very minor suggestion.

imap_processing/ultra/l1b/ultra_l1b_extended.py Outdated Show resolved Hide resolved
imap_processing/ultra/l1b/ultra_l1b_extended.py Show resolved Hide resolved
@laspsandoval laspsandoval merged commit 127e5c3 into IMAP-Science-Operations-Center:dev Sep 3, 2024
17 checks passed
@laspsandoval laspsandoval deleted the ultra_l1b_extended_ssd branch September 3, 2024 15:47
@bourque bourque added this to the Sept 2024 milestone Sep 9, 2024
@bourque bourque added Ins: Ultra Related to the IMAP-Ultra instrument Level: L1 Level 1 processing labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subagonsouth subagonsouth subagonsouth approved these changes

@sdhoyt sdhoyt sdhoyt approved these changes

Assignees

@laspsandoval laspsandoval

Labels
Ins: Ultra Related to the IMAP-Ultra instrument Level: L1 Level 1 processing
Projects
IMAP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laspsandoval @sdhoyt @subagonsouth @bourque