MNT/TST: Update SWAPI packet definition and tests #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes some unnecessary utils functions and moves over to packet_file_to_datasets()
greglucas
added
Ins: SWAPI
greglucas
commented
Aug 30, 2024
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def decom_test_science_data(swapi_l0_test_data_path): |
There was a problem hiding this comment.
It is interesting that they gave you "derived_values" for the science data, but didn't use any "derived_values" for the housekeeping. That is why we have these two different fixtures here now.
There was a problem hiding this comment.
yes. That's why I had to add if and else in test but your approach is much better.
9 tasks
|
The failing tests are due to an issue upstream with space_packet_parser that has already been fixed, but not released yet. medley56/space_packet_parser#54 I'm not sure there is much we can do about this until the fix is out. |
tech3371
approved these changes
Aug 30, 2024
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def decom_test_science_data(swapi_l0_test_data_path): |
There was a problem hiding this comment.
yes. That's why I had to add if and else in test but your approach is much better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some unnecessary utils functions and moves over to
packet_file_to_datasets()Note that updating the packet definition also changed the
plan_id_scienceback toplan_idwhich was in the original spreadsheet definition. This is because they can now have different bit lengths between the packets.The packet definition also does not have the
AUTpacket defined in it anymore, do we want to add that one to the definition, or leave it out? I left it out for now and just removed that test.