SWAPI Quality Flag #805
Merged
SWAPI Quality Flag #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech3371
added
enhancement
tech3371
requested review from
bourque,
sdhoyt,
greglucas,
subagonsouth,
vmartinez-cu,
laspsandoval and
maxinelasp
and removed request for
a team
|
Please update this page when you have a chance: |
laspsandoval
reviewed
Sep 4, 2024
| @@ -79,7 +79,7 @@ def test_decompress_count(): | |||
| # compressed + no-overflow, compressed + overflow, no compression | |||
| raw_values = np.array([[12, 0xFFFF, 12]]) | |||
| compression_flag = np.array([[1, 1, 0]]) | |||
| expected = np.array([[12 * 16, -1, 12]]) | |||
| expected = np.array([[12 * 16, np.iinfo(np.int32).max, 12]], dtype=np.int32) | |||
| returned_value = decompress_count(raw_values, compression_flag) | |||
| np.testing.assert_array_equal(returned_value, expected) | |||
|
|
|||
There was a problem hiding this comment.
It would be helpful to have one test that shows the flags set in dataset["swp_flags"].
There was a problem hiding this comment.
for sure! I will add a test for this.
There was a problem hiding this comment.
Laura, actually I am going to wait to add the test and do this in future PR if you don't mind. Right now, all flags are set to 0 but SWAPI will provide me some useful data that will have some good flags set. I will add the test with that change.
bourque
approved these changes
Sep 4, 2024
tech3371
commented
Sep 5, 2024
tech3371
force-pushed
the
swapi_l2_flag
branch
from
bc38e92
to
c051959
Compare
|
I am going to merge this since there was not change request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Uses Quality flags class to set SWAPI quality flags. Closes #707
Updated Files
Testing
update test based on above changes