Updated CoDICE XTCE files from imap_xtce tool #812
Conversation
bourque
added
Ins: CoDICE
bourque
requested review from
greglucas,
subagonsouth,
tech3371 and
joeymukherjee
and removed request for
a team
imap_processing/codice/codice_l0.py
Outdated
| # TODO: Currently need to use the 'old' packet definition for housekeeping | ||
| # because the test housekeeping packet has LAST_OPCODE=0, and the | ||
| # telemetry definition "STATES" tab doesn't allow for a 0 value for | ||
| # this. Need to figure out if the test packet is bad, or the telemetry | ||
| # definition is wrong. |
There was a problem hiding this comment.
This is an interesting case. Does an Enumeration need to exist for every possible value or should space_packet_parser just return the raw_value here and not decode anything rather than raising an error? Gavin might have some insight here as well.
There was a problem hiding this comment.
From what I understand from Gavin's comment in the xtce slack channel, it sounds like his preference would be to explicitly define what a value of 0 means in the packet definition file. I will ask Joey about this in our next tagup.
imap_processing/codice/codice_l0.py
Outdated
| packets: dict[int, xr.Dataset] = packet_file_to_datasets( | ||
| packet_file, xtce_packet_definition | ||
| ) | ||
| packets = packet_file_to_datasets(packet_file, xtce_packet_definition) | ||
|
|
||
| return packets |
There was a problem hiding this comment.
can you return the dataset now without assigning since it's not packets anymore? or this file itself might go away like mine did for SWE and SWAPI once your HK issue is fixed.
There was a problem hiding this comment.
Good call, this should really be called datasets now instead of packets. But I think I will keep the module around, at least for now, as a way to distinguish L0 code from L1 code.
| <xtce:EnumeratedParameterType name="COD_NHK.LAST_OPCODE" signed="false"> | ||
| <xtce:IntegerDataEncoding sizeInBits="16" encoding="unsigned" /> | ||
| <xtce:EnumerationList> | ||
| <xtce:Enumeration value="4096" label="COD_NOOP" /> |
There was a problem hiding this comment.
Can you add this to get around your above issue temporarily or will this cause issue later on?
| <xtce:Enumeration value="4096" label="COD_NOOP" /> | |
| <xtce:Enumeration value="0" label="TESTING" /> | |
| <xtce:Enumeration value="4096" label="COD_NOOP" /> |
There was a problem hiding this comment.
Based on Gavin's comments I think this will likely be the workaround I go with, but I want to ask Joey about this first.
|
Nice consolidation! |
|
After discussing with Joey, a |
Change Summary
Overview
This PR updates the CoDICE XTCE files from running the new
imap_xtcecommand line tool. As such, there is now a single telemetry definition file for all packet types. However, I need to retain the oldP_COD_NHK.xmlfile until I can sort out a discrepancy with one of the fields that is causing an error (marked as aTODOin the code).New Files
codice_packet_definition.xmlimap_xtcetoolDeleted Files
Updated Files
imap_processing/codice/codice_l0.pyimap_processing/codice/codice_l1a.pycodice_lo.decom_packets()insteadimap_processing/codice/constants.pyCloses #768