Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ultra l1b extended energy #825

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Ultra l1b extended energy #825

merged 6 commits into from
Sep 16, 2024

Conversation

laspsandoval
Copy link
Contributor

Change Summary

Overview

Added functions to calculate energy.

Updated Files

  • ultra_l1b_extended.py
    • added ph and ssd energy functions
  • lookup_utils.py
    • minor changes using iloc

Testing

  • test_ultra_l1b_extended.py
    • tests_ultra_l1b_extended.py
  • test_lookup_utils.py
    • test lookup_utils.py

@laspsandoval laspsandoval self-assigned this Sep 11, 2024
subagonsouth
subagonsouth approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laspsandoval laspsandoval merged commit 094afd8 into IMAP-Science-Operations-Center:dev Sep 16, 2024
17 checks passed
@laspsandoval laspsandoval deleted the ultra_l1b_extended_energy branch September 16, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subagonsouth subagonsouth subagonsouth approved these changes

@sdhoyt sdhoyt Awaiting requested review from sdhoyt

Assignees

@laspsandoval laspsandoval

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laspsandoval @subagonsouth