Ultra l1c bin data #829
Open
Ultra l1c bin data #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laspsandoval
added
Ins: Ultra
laspsandoval
requested review from
subagonsouth and
sdhoyt
and removed request for
sdhoyt and
subagonsouth
| return az, el | ||
|
|
||
|
|
||
| def bin_space( |
There was a problem hiding this comment.
You might consider checking out the 2d histogram function. I believe it would be ideal for this binning:
https://numpy.org/doc/stable/reference/generated/numpy.histogram2d.html
| energy_bin_edges = build_energy_bins() | ||
|
|
||
| # Find the appropriate bin index. | ||
| energy_bin_idx = np.searchsorted(energy_bin_edges, energy, side="right") - 1 |
There was a problem hiding this comment.
Any reason not to use np.histogram here? https://numpy.org/doc/stable/reference/generated/numpy.histogram.html#numpy.histogram
|
|
||
| Returns | ||
| ------- | ||
| az_midpoint : np.ndarray |
There was a problem hiding this comment.
I guess that I am missing something. Is there a reason that this function doesn't just produce the 2d histogram data?
| Returns | ||
| ------- | ||
| energy_start : np.ndarray | ||
| Start of energy bin. |
There was a problem hiding this comment.
Same question here... When I think of a function that "bins" data, it returns a histogram rather than the bin center location for each input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Add spatial and energy binning equations.
Updated Files
Testing