Separate IDEX L1 into L1a and L1b #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bourque
added
Ins: IDEX
bourque
requested review from
greglucas,
subagonsouth and
tech3371
and removed request for
a team
|
Closes #832 |
greglucas
approved these changes
Sep 12, 2024
| @@ -21,7 +21,7 @@ The general filename convention is as follows:: | |||
| * CoDICE: ``l0``, ``l1a``, ``l1b``, ``l2``, ``l3`` | |||
| * GLOWS: ``l0``, ``l1a``, ``l1b``, ``l2``, ``l3a``, ``l3b``, ``l3c``, ``l3d`` | |||
| * HIT: ``l0``, ``l1a``, ``l1b``, ``l2``, ``l3`` | |||
| * IDEX: ``l0``, ``l1``, ``l2``, ``l3`` | |||
| * IDEX: ``l0``, ``l1a``, ``l1b``, ``l2``, ``l3`` | |||
There was a problem hiding this comment.
Do we need to update the sds-data-manager repo with this as well for the dependency graph? If so, can you open an issue for that.
There was a problem hiding this comment.
Ah yes, good call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IDEX team informed us that they expect separate L1a and L1b data products (with the L1b data products being basically the same as the L1a data products, only converted from DN to pC). This PR makes various changes in order to distinguish between the two levels. Changes to create L1b products will be made in a separate PR.
I also took this PR as an opportunity to move the
idex_l0.pyandidex_l1[a|b].pymodules into the same directory. In my opinion, keeping L0 and L1 code in separate subpackages is overkill.