Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SWAPI L3 levels to the list of valid levels #847

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Added SWAPI L3 levels to the list of valid levels #847

merged 2 commits into from
Sep 17, 2024

Conversation

tech3371
Copy link
Contributor

Change Summary

Overview

small update to add SWAPI L3 levels

@tech3371 tech3371 added the Ins: SWAPI Related to the SWAPI instrument label Sep 16, 2024
@tech3371 tech3371 added this to the Sept 2024 milestone Sep 16, 2024
@tech3371 tech3371 self-assigned this Sep 16, 2024
maxinelasp
maxinelasp approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@maxinelasp maxinelasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be updated in imap-data-access? Good catch!

@tech3371
Copy link
Contributor Author

Does this need to be updated in imap-data-access? Good catch!

@maxinelasp I looked on imap-data-access before but looks like we don't need to update there. There, we only stored all valid levels whereas here, we go more into instrument specific valid levels.

@tech3371 tech3371 merged commit 66eb9f0 into IMAP-Science-Operations-Center:dev Sep 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxinelasp maxinelasp maxinelasp approved these changes

@greglucas greglucas Awaiting requested review from greglucas

Assignees

@tech3371 tech3371

Labels
Ins: SWAPI Related to the SWAPI instrument
Projects
IMAP
Status: Done
Milestone
Sept 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@tech3371 @maxinelasp