FIX: Update SWAPI quality flags to work with numpy 2+ #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subagonsouth
approved these changes
Sep 17, 2024
greglucas
merged commit 2f79f29
into
IMAP-Science-Operations-Center:dev
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
SWAPI tests were failing locally for me because I had numpy2+ installed. It looks like we need to bitwise or the actual Enum value rather than the Enum itself. It might be worth upstreamining this issue to Numpy, but this fixes the issue here for now.
Additionally, regenerate the
poetry.lockfile from the pre-commit rather than the local environment. @subagonsouth as an FYI, it is good to let pre-commit take care of the updates to the lock file because otherwise it is constantly getting changed by people with different versions of poetry it seems like.