Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointing frame lambda #325

Conversation

laspsandoval
Copy link
Contributor

@laspsandoval laspsandoval commented Aug 14, 2024

Change Summary

Overview

Provides algorithm that mocks Nick Duttons pointing frame (DPS frame) kernel generation. Note that I have TODOs that will be included in the next tickets.

New Files

  • pointing_frame_handler.py
    • writes a new C-kernel file containing the averaged pointing data
  • changes in the environment: poetry.lock, requirements.txt, pyproject.toml

Testing

  • test_pointing_frame_handler.py
    • tests pointing_frame_handler.py
  • imap_science_0001.tf
    • pointing frame kernel used for test data
  • imap_sclk_0000.tsc
    • spacecraft clock kernel used for test data
  • imap_wkcp.tf
    • spacecraft frame kernel used for test data

Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some initial comments, but want to bring a bigger question up as I might not be up to speed on all of the past decisions. This seems like 2 things going on to me here. 1) how to create the new frame kernel, and 2) how to use that within the infrastructure. Right now those are blended together in this single PR, but I'd like to propose separating them out. (1) could be in imap_processing so that all of our SPICE helper routines etc. are in a single location and we load kernels, and save kernels using the same exact utilities. (2) we can make a lambda/batch/whatever that depends on imap_processing if needed and calls this routine. I personally like the separation of concerns so we don't force infrastructure decisions based on processing, or vice-versa.

I think that decision will impact future reviews, so didn't review everything in-depth.

@laspsandoval
Copy link
Contributor Author

laspsandoval commented Aug 15, 2024

@greglucas I thought about your question for a while too. Let's talk at Monday's meeting if that is ok. I re-read your comment and probably you are right. It would be easy to move it to imap_processing, but let's discuss.

@laspsandoval laspsandoval deleted the pointing_frame branch September 13, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants