Simplify IStoredFile adaptation #31
Conversation
This requires collective/collective.collabora#12 As a driveby, fix an encoding declaration that drives my editor crazy.
imio/dms/mail/adapters.py
Outdated
|
|
||
| @adapter(IPODTemplate) | ||
| @implementer(IStoredFile) | ||
| class StoredPodTemplate(object): |
There was a problem hiding this comment.
I think it's missing DXStoredFile here.
After that, I still get error *** AttributeError: file when adapting my "PODTemplate" file with IStoredFile
There was a problem hiding this comment.
I added the baseclass. That attributeerror indicates, that your adapter is not properly kicking in and it's using the upstream collective.collabora adapter instead - is it true that you get this error already on your own code? I don't have a working dms.mail install so I can't trace this for you.
There was a problem hiding this comment.
Yes, in fact, I get an error "This page does not exist" when visiting "/my-pod-file/@@collabora-edit" that I was not having before.
Using a breakpoint in CollaboraEditView's init method showed me the error on line 44. I have no logs otherwise
There was a problem hiding this comment.
Like I said, I don't have a working interactive install. If you'd like me to fix this, I need an integrationtest that reproduces the failure.
There was a problem hiding this comment.
I found the issue: collective/collective.collabora#13
This requires collective.collabora 1.1.0, which contains collective/collective.collabora#12.
As a driveby, fix an encoding declaration that drives my editor crazy.