Skip to content

Added hemisphere property to brainLocation schema #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added hemisphere property to brainLocation schema #350

wants to merge 3 commits into from

Conversation

@annakristinkaufmann
Copy link
Collaborator

@annakristinkaufmann annakristinkaufmann commented Nov 5, 2019

Fixes #349

@annakristinkaufmann annakristinkaufmann self-assigned this Nov 5, 2019
MFSY
MFSY reviewed Nov 5, 2019
View reviewed changes
shapes/neurosciencegraph/commons/brainlocation/schema.json
},
{
"path": "nsg:hemisphere",
"name": "Brain hemisphere",
Copy link
Contributor

@MFSY MFSY Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nsg:brainHemisphere may be ?

Copy link
Collaborator Author

@annakristinkaufmann annakristinkaufmann Nov 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Done.

Copy link
Collaborator Author

@annakristinkaufmann annakristinkaufmann Nov 6, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @MFSY. I have updated t he property to "brainHemisphere"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MFSY MFSY MFSY left review comments

@jonathanlurie jonathanlurie Awaiting requested review from jonathanlurie

At least 1 approving review is required to merge this pull request.

Assignees

@annakristinkaufmann annakristinkaufmann

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add hemisphere property to BrainLocation schema

2 participants

@annakristinkaufmann @MFSY