Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant text #744

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Remove redundant text #744

merged 1 commit into from
Oct 30, 2023

Conversation

PatriOr
Copy link
Contributor

@PatriOr PatriOr commented Oct 27, 2023

I found that these two paragraphs were a bit redundant and I decided to keep the first.

This is my first pull request and I am happy to contribute to the mooc :)

@ArturoAmorQ
Copy link
Collaborator

Thanks for pointing this out @PatriOr. Now that you are working on this notebook, would you mind changing verbs to present mode (avoid future mode) in the whole text?

Copy link
Collaborator

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is already a net improvement, let's merge. The update to use the present tense can happen in a follow-up PR.

@ogrisel ogrisel merged commit 1fe4a1d into INRIA:main Oct 30, 2023
@ogrisel
Copy link
Collaborator

ogrisel commented Oct 30, 2023

Thanks @PatriOr!

@ArturoAmorQ
Copy link
Collaborator

Thanks @PatriOr and congrats on your first merge!

github-actions bot pushed a commit that referenced this pull request Oct 30, 2023
@PatriOr PatriOr deleted the rephrase_tree branch November 6, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants