-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type ID extension #68
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
- Coverage 93.57% 93.48% -0.09%
==========================================
Files 44 44
Lines 1976 1966 -10
==========================================
- Hits 1849 1838 -11
- Misses 127 128 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. There is a single codecov warning but I'm not sure you need to handle it at all.
The codecov warning is for a line that is impossible to actually hit, but it makes the type checker happy |
@vladimirdimov11 I apologize for the delay. The original Hive maintainer has returned from his hiatus, and I need to investigate how this affects Hive CE, if at all. |
@Rexios80 thanks for the info. I was just started wondering if my approve isn't visible on the PR |
Resolves #67
Adds an internal type ID to inform Hive to read the next 2 bytes as the real type ID
Hive uses this type ID when the given type ID is greater than the current max value of 255
Here is a representation of how the new IDs are handled
![image](https://private-user-images.githubusercontent.com/7896519/404585187-0ba289c5-1a53-4700-97a9-905d77a12eb9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjA3NDgsIm5iZiI6MTczOTQ2MDQ0OCwicGF0aCI6Ii83ODk2NTE5LzQwNDU4NTE4Ny0wYmEyODljNS0xYTUzLTQ3MDAtOTdhOS05MDVkNzdhMTJlYjkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTNUMTUyNzI4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjYxYjdmMDg2ZGMwY2ExMjA0YmExOWUxMWI4YTRmOGQ5MzI4OGQ0NzI3ODk4ZjVkY2I4ODU0MjhjODVlYjUwMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.-_Rvu40Perf2TdBaFrdboAJBeH3K9-_z7eUihkMvNTk)