c/fix(Scroller): fix non-auto-starting scroller #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
== Cause The scroller animation did not start because the `animation-duration` property had the value 0 initially. This was caused by `el.scrollWidth` being 0 initially because there were no elements in `items`, which was caused by PromptSelector loading the items asynchroneously on mount. == Fix The reactive expression now incorporates the state of `items` for recalculation.
thlehmann-ionos
force-pushed
the
tl/dev/fix-scroller
branch
from
2335e69 to
d73fbcb
Compare
Author
|
fyi @bromiesTM |
bromiesTM
approved these changes
Apr 24, 2025
bromiesTM
left a comment
bromiesTM
left a comment
There was a problem hiding this comment.
More types would be great but review ok nevertheless
Author
|
Done @bromiesTM |
bromiesTM
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
== Cause
The scroller animation did not start because the
animation-durationproperty had the value 0 initially.
This was caused by
el.scrollWidthbeing 0 initially because therewere no elements in
items, which was caused by PromptSelector loadingthe items asynchroneously on mount.
== Fix
The reactive expression now incorporates the state of
itemsforrecalculation.