Skip to content

Conversation

@thlehmann-ionos
Copy link

  • Remove pyodide (frontend code execution is disabled)
  • Remove cypress (e2e tests) (they're broken and we modified the UI drastically) (also removed one critical npm vulnerability)

@thlehmann-ionos thlehmann-ionos changed the base branch from ionos-dev to feature/remove-heavy-unneeded-dependencies October 7, 2025 14:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes frontend Python execution (Pyodide) and Cypress E2E testing infrastructure to eliminate unused dependencies and simplify the build.

  • Removed all Pyodide-related workers, execution logic, and configuration options except for retaining only the Jupyter engine.
  • Removed Cypress test suite, related scripts, and dependencies.
  • Cleaned package scripts to drop Pyodide fetch step and eliminated unused dependencies (pyodide, cypress, eslint-plugin-cypress, undici).

Reviewed Changes

Copilot reviewed 14 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/routes/+layout.svelte Removed Pyodide worker import and Python execution handler branch.
src/lib/workers/pyodide.worker.ts Deleted Pyodide worker implementation.
src/lib/pyodide/pyodideKernel.worker.ts Deleted alternate Pyodide kernel worker.
src/lib/pyodide/pyodideKernel.ts Deleted Pyodide kernel wrapper class.
src/lib/components/chat/Messages/CodeBlock.svelte Stripped Python execution UI and worker logic.
src/lib/components/admin/Settings/CodeExecution.svelte Restricted engines list to Jupyter only.
package.json Removed Pyodide/Cypress scripts and dependencies.
cypress/** (multiple) Removed Cypress config, support, tests, and fixtures.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@thlehmann-ionos thlehmann-ionos marked this pull request as ready for review October 10, 2025 18:32
@thlehmann-ionos thlehmann-ionos force-pushed the feature/remove-heavy-unneeded-dependencies branch from d38d5db to ab970b1 Compare October 13, 2025 13:30
@thlehmann-ionos thlehmann-ionos force-pushed the feature/remove-pyodide branch 2 times, most recently from 9e0de8f to a01d928 Compare October 15, 2025 07:54
@thlehmann-ionos thlehmann-ionos force-pushed the feature/remove-heavy-unneeded-dependencies branch from ab970b1 to 46d09ca Compare October 15, 2025 07:54
@toscharfmoc
Copy link

looks good to me

@toscharfmoc toscharfmoc self-requested a review October 24, 2025 14:34
Copy link

@toscharfmoc toscharfmoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thumbs up

@thlehmann-ionos thlehmann-ionos force-pushed the feature/remove-heavy-unneeded-dependencies branch from 46d09ca to aaac397 Compare October 24, 2025 14:39
@thlehmann-ionos thlehmann-ionos changed the base branch from feature/remove-heavy-unneeded-dependencies to ionos-dev October 24, 2025 14:40
* They're broken anyway
* We changed the application in a way that they're no longer compatible

Refs: PRODAI-198
* Code execution is not enabled
* Building pyodide heavily contributes to the build time and image size

Refs: PRODAI-198
@thlehmann-ionos thlehmann-ionos merged commit cea3c29 into ionos-dev Oct 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants