fix(makefile): extract custom npm packages build as build_custom_npms… #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Makefile build process by extracting custom npm package builds into a separate target called build_custom_npms. This allows developers to rebuild only the custom npm packages without rebuilding the entire Nextcloud application.
Key changes:
- Extracted custom npm package builds into a dedicated
build_custom_npmstarget - Updated build dependencies to use the new target
- Removed redundant
.remove_node_modulesdependency frombuild_locally
printminion-co
force-pushed
the
mk/dev/extract_custom_npm_build
branch
from
df7bc2b to
b915439
Compare
- Change 'patch_shippend_json' to 'patch_shipped_json' - Ensures proper phony target declaration Signed-off-by: Misha M.-Kupriyanov <[email protected]>
… target - Add all missing targets to .PHONY declaration for proper phony behavior - Add comprehensive 'clean' target that removes build artifacts - Keep original .remove_node_modules target for backward compatibility Signed-off-by: Misha M.-Kupriyanov <[email protected]>
- Split .PHONY declarations into logical groups with descriptive comments - Groups: core targets, NPM packages, main build, applications, themes, config/packaging, meta targets - Improves readability and maintainability of the Makefile Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…ronment variables - Add comment explaining TARGET_PACKAGE_NAME variable purpose - Document required FONTAWESOME_PACKAGE_TOKEN environment variable - Improves developer onboarding and reduces setup confusion Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
force-pushed
the
mk/dev/extract_custom_npm_build
branch
from
b915439 to
4d16659
Compare
… task in order to be able to rebuild only custom npm packages Signed-off-by: Misha M.-Kupriyanov <[email protected]>
in order to rebuild without rebuilding custom npm packages Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Reintroduce the help target in the Makefile to provide usage instructions for available make commands. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
force-pushed
the
mk/dev/extract_custom_npm_build
branch
from
4d16659 to
275a984
Compare
Updated the Makefile to suppress echo output for build messages by adding '@' before the echo commands. This change improves the output readability during the build process. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
This change introduces a check for the FONTAWESOME_PACKAGE_TOKEN environment variable before building custom npm packages, ensuring that the necessary token is set to avoid build failures. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Enhance the Makefile by adding echo statements to provide feedback during the build process, including cleaning artifacts, building packages, and generating version files. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Enhance visibility of build process by adding informative prefix to echo statements in the Makefile. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
force-pushed
the
mk/dev/extract_custom_npm_build
branch
from
3b28340 to
a9b4da3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… task
in order to be able to rebuild only custom npm packages