Skip to content

Conversation

@dsteininger86
Copy link
Contributor

No description provided.

@thlehmann-ionos
Copy link
Collaborator

Please either split the commit into three changes.

Extend the commit message for the provider ID change to explain why this is done, something along the line Separate provider identifier from client ID to be able to change the client ID while keeping the provider constant. This allows for editing the provider config.

Thank you.

Apart from that looks good to me.

@dsteininger86
Copy link
Contributor Author

closed because change are splitted now in to three parts:

See new PRs:
feat(user_oidc): support for uid mapping #60
feat(user_oidc): support for extra claims #61
feat(user_oidc): use ENV as provider identifier #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants