feat: configure richdocuments for collabora #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bromiesTM
force-pushed
the
kh/dev/configure-richdocuments
branch
3 times, most recently
from
ad02695 to
f3add9d
Compare
printminion-co
requested changes
Apr 1, 2025
bromiesTM
force-pushed
the
kh/dev/configure-richdocuments
branch
from
f3add9d to
ddce08a
Compare
printminion-co
force-pushed
the
kh/dev/configure-richdocuments
branch
from
3470c52 to
0d20ca5
Compare
printminion-co
requested changes
Apr 9, 2025
Contributor
printminion-co
left a comment
printminion-co
left a comment
There was a problem hiding this comment.
review ok if amends are accepted
- lets move
richdocumentsdisable/enable logic to configure.sh. - lets ensure yes/no values is used for
disable_certificate_verificationbecause COLLABORA_SELF_SIGNED env is set to boolean via helm
Signed-off-by: Kai Henseler <[email protected]>
bromiesTM
force-pushed
the
kh/dev/configure-richdocuments
branch
from
d7f6b61 to
1ac0ef9
Compare
printminion-co
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.