feat(config): add hidrive config file #98
Conversation
tanyaka
left a comment
tanyaka
left a comment
There was a problem hiding this comment.
I would rename the file to server.confog.php as it reflects the name of removed config in https://gitlab.git-moc.server.lan/nextcloud/easynextcloud/helm/-/merge_requests/123/diffs?file=c3e8d9f5c18a51f1bc10aee4caa587b6a7454246#c3e8d9f5c18a51f1bc10aee4caa587b6a7454246_15_15
configs/hidrive.config.php
Outdated
| 'forwarded_for_headers' => array( | ||
| '0' => 'HTTP_X_FORWARDED_FOR', | ||
| ), |
There was a problem hiding this comment.
'forwarded_for_headers' => [ '0' => 'HTTP_X_FORWARDED_FOR', ],
this syntax is used in others config files. 🤷
|
We need to add 'NEXTCLOUD_LOGLEVEL', 'PASSWORD_SALT' and 'SECRET' to .env.sample in nc-docs-and-tools repo. Would be nice to have an explanation what they are. 🤔 |
| 'loglevel' => (string)getenv('NEXTCLOUD_LOGLEVEL'), | ||
| 'log_file' => '', | ||
| 'passwordsalt' => (string)getenv('PASSWORD_SALT'), | ||
| 'secret' => (string)getenv('SECRET'), |
There was a problem hiding this comment.
could also be beneficial to add a check to our configure script if those env vars are properly set and advise the user to do so otherwise (as for most env vars we have there)
fracado
force-pushed
the
fb/dev/add-hidrive-config
branch
from
c5a754d to
1915ab5
Compare
printminion-co
force-pushed
the
fb/dev/add-hidrive-config
branch
2 times, most recently
from
20295ee to
5dddeeb
Compare
printminion-co
left a comment
printminion-co
left a comment
There was a problem hiding this comment.
additional changes are required in order for dev container to use getenv logic.
the change is already made in dev repo
configs/server.config.php
Outdated
| 'memcache.local' => '\OC\Memcache\APCu', | ||
| 'memcache.locking' => '\OC\Memcache\Redis', | ||
| 'memcache.distributed' => '\OC\Memcache\Redis', |
There was a problem hiding this comment.
lets not move 'memcache.*' as for now to IONOS - since we have no macache locally.
configs/server.config.php
Outdated
| 'files_external_allow_create_new_local' => false, | ||
| 'allow_local_remote_servers' => true, | ||
| 'log_type' => 'errorlog', | ||
| 'loglevel' => (string)getenv('NEXTCLOUD_LOGLEVEL'), |
There was a problem hiding this comment.
lets cast to int. Since value should be a integer
configs/server.config.php
Outdated
|
|
||
| $CONFIG = [ | ||
| 'htaccess.RewriteBase' => '/', | ||
| 'overwriteprotocol' => 'https', |
There was a problem hiding this comment.
lets not move overwriteprotocol as for now since we dont have https configured in localdev
There was a problem hiding this comment.
lets rename the file to server-base.config.php in order not to collide with the helm chart file server.config.php
Signed-off-by: Franziska Bath <[email protected]> Co-authored-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
force-pushed
the
fb/dev/add-hidrive-config
branch
from
5f2800d to
8e3b64a
Compare
No description provided.