[master] MVP PR #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaetty
force-pushed
the
new_develop
branch
3 times, most recently
from
0367d40 to
ca6cd42
Compare
EmilBohleber
force-pushed
the
new_develop
branch
2 times, most recently
from
17534a8 to
7a4fb34
Compare
chaetty
force-pushed
the
new_develop
branch
2 times, most recently
from
1febbab to
69373d5
Compare
EmilBohleber
force-pushed
the
new_develop
branch
3 times, most recently
from
c46237c to
0469a0d
Compare
This is actual the fix which propagtes the palette correctly to its children
Since nearly every color in the application should have the same color, this should be no problem. At many places we set the color explicit, which can be removed now. In case that another color is needed, it can be overwritten locally
It seems Text and Text Fields is not controlled by the palette as expceted
EmilBohleber
force-pushed
the
new_develop
branch
from
62afbbc to
ed94950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge. PR for Customization Service