HDFRONT-6777: activate GA4 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Intermediate feedback:
Review ongoing. |
Collaborator
|
Collaborator
|
Review done for the code part, ongoing for manual tests. |
Collaborator
|
Is the Makefile still relevant and uptodate? Please revise the instructions in the readme. |
printminion-co
force-pushed
the
mk/dev/HDFRONT-6777-enc_configure
branch
10 times, most recently
from
d5cf50f to
585b5cb
Compare
Contributor
Author
|
review amended
|
printminion-co
force-pushed
the
mk/dev/HDFRONT-6777-enc_configure
branch
12 times, most recently
from
6e46bfd to
55b6d37
Compare
printminion-co
force-pushed
the
mk/dev/HDFRONT-6777-enc_configure
branch
from
55b6d37 to
7882c51
Compare
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
https://developers.google.com/tag-platform/tag-manager/restrict Signed-off-by: Misha M.-Kupriyanov <[email protected]>
url won't be passed to GTM https://developers.google.com/tag-platform/tag-manager/restrict Signed-off-by: Misha M.-Kupriyanov <[email protected]>
https://developers.google.com/tag-platform/security/guides/csp Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
in order to be compatible with future php releases Signed-off-by: Misha M.-Kupriyanov <[email protected]>
run: npm install Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
in order to avoid exception Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
in order to reflect what linter does Signed-off-by: Misha M.-Kupriyanov <[email protected]>
for security reasons Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
since we are programming for v29 Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
in order to add additional values Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Error: Using default tag: latest latest: Pulling from deepdiver/docker-oracle-xe-11g [DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of docker.io/deepdiver/docker-oracle-xe-11g:latest to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
force-pushed
the
mk/dev/HDFRONT-6777-enc_configure
branch
from
5d0d430 to
7beba14
Compare
Signed-off-by: Thomas Lehmann <[email protected]>
Collaborator
|
Explain magic strings in b22d4cb |
Collaborator
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.