HDFRONT-6777: activate GA4 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

thlehmann-ionos merged 38 commits into main from mk/dev/HDFRONT-6777-enc_configure

Jul 11, 2024

Contributor

printminion-co commented May 15, 2024 •

edited

Loading

check if CSP header is properly set and delivered via browser

Collaborator

thlehmann-ionos commented May 23, 2024

Intermediate feedback:

We agreed upon the naming scheme "nc-", please rename the repo accordingly (See Google group chat amongst Matthias, you and me, search for "Neue Repos werden mit "nc-" Prefixed")
Consider renaming the app to "googleanalytics" (since "analytics" is already an official name)
Please remove the PHP tests
Please remove the .gitattributes as it declares js/track.js as binary which hides changes in git log. There's also no reason for it.
What's the reason for the reuse: commit and added license files with copyright holder/date placeholders. Where is this from?

Review ongoing.

thlehmann-ionos reviewed

View reviewed changes

js/track.js Outdated Show resolved Hide resolved

Collaborator

thlehmann-ionos commented May 23, 2024

Tests are missing for Application.php and JavaScriptController.php
Some workflow Jobs failed. Please have a look at it and fix this.
Some php linter jobs were fixed by limiting the PHP versions to 8.1 in matrix tests (see my test pull request: tl/review/mk/dev/hdfront 6777 enc configure [TEST, dont merge] #3)

Collaborator

thlehmann-ionos commented May 23, 2024

Review done for the code part, ongoing for manual tests.

Collaborator

thlehmann-ionos commented May 23, 2024

Is the Makefile still relevant and uptodate? Please revise the instructions in the readme.

thlehmann-ionos reviewed

View reviewed changes

js/track.js Outdated Show resolved Hide resolved

printminion-co force-pushed the mk/dev/HDFRONT-6777-enc_configure branch 10 times, most recently from d5cf50f to 585b5cb Compare

May 29, 2024 16:33

Contributor Author

printminion-co commented May 30, 2024

review amended

added rudimentary php tests
made PR green

printminion-co force-pushed the mk/dev/HDFRONT-6777-enc_configure branch 12 times, most recently from 6e46bfd to 55b6d37 Compare

June 3, 2024 08:06

printminion-co force-pushed the mk/dev/HDFRONT-6777-enc_configure branch from 55b6d37 to 7882c51 Compare

June 12, 2024 13:34

printminion-co added 24 commits

July 11, 2024 11:23


          track.js: remove comment lines

259061c

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          track.js: disable eslint for GTM snippet

a07d7f1

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          track.js: restrict referrer

dd72021

https://developers.google.com/tag-platform/tag-manager/restrict
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          track.js: restrict url

b22fcdb

url won't be passed to GTM
https://developers.google.com/tag-platform/tag-manager/restrict

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          Application.php: allow GA4 CSP

42c548b

https://developers.google.com/tag-platform/security/guides/csp
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          tests: remove initial php tests

06dbdc0

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          github workflow: switch to php v8.1, v8.2

813aa33

in order to be compatible with future php releases

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          (!) rename app "enc_analytics" to "googleanalytics"

5a15abe

run: npm install
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          upgrade composer.lock

a69f199

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          add/change link to bugtracker

ba3d89c

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          add php-cs-fixer target dir

0b529bc

in order to avoid exception

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          .gitignore exclude .phpunit.result.cache

bd1846f

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          add php tests

dc5c642

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          reformat php with php-cs-fixer

eaa4297

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          composer: change name, update dependencies

a8c521b

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          workflows: change lint names

f43b1e2

in order to reflect what linter does

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          workflows: use hashes as image references

061dae3

for security reasons

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          workflows: set node version to 20

99df2c2

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          workflows: add dependabot

4590acc

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          composer: upgrade nextcloud/ocp to v29.0.1

e04a0f2

since we are programming for v29

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          workflows: phpunit tests with nextcloud stable29

cd81d03

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          Application.php: split CSP domains setting

c89d3a5

in order to add additional values

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          Application.php: add CSP for GTM preview mode

410a54d

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>


          workflows: phpunit-oci.yml fix docker v1 deprecation

7beba14

Error:
Using default tag: latest
  latest: Pulling from deepdiver/docker-oracle-xe-11g
  [DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of docker.io/deepdiver/docker-oracle-xe-11g:latest to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

printminion-co force-pushed the mk/dev/HDFRONT-6777-enc_configure branch from 5d0d430 to 7beba14 Compare

July 11, 2024 09:23


          track.js: document the "f" and "u" magic strings

b22d4cb

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>

Collaborator

thlehmann-ionos commented Jul 11, 2024

Explain magic strings in b22d4cb

Collaborator

thlehmann-ionos commented Jul 11, 2024

As per docs the injected script is configured to not send sensitive URL and referrer ✔️
gtm.js is loaded (whether the tracking is sensible is up to the product management) ✔️
Unit/integration tests OK ✔️

thlehmann-ionos merged commit 0aa10cf into main

thlehmann-ionos deleted the mk/dev/HDFRONT-6777-enc_configure branch

July 11, 2024 11:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet