Skip to content

Conversation

@printminion-co
Copy link
Contributor

@printminion-co printminion-co commented Jul 9, 2025

in order to avoid hardcoded values use dynamic matrix

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…s/deep-copy, nikic/php-parser, and phpunit

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Nextcloud workflows to use the centralized organization templates and bumps the nextcloud/ocp dependency.

  • Bump nextcloud/ocp from v31.0.5 to v31.0.6 in composer.json
  • Switch all GitHub Actions workflows to the org-provided templates, update triggers to pull_request, permissions, concurrency, and pinned action versions
  • Add --no-scripts to composer remove in PHP unit workflows and update service images

Reviewed Changes

Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
composer.json Bump nextcloud/ocp to v31.0.6
.github/workflows/reuse.yml Switch to org-provided REUSE workflow; restrict trigger to PR; pin checkout & reuse-action versions
.github/workflows/phpunit-sqlite.yml Migrate to org template; PR-only trigger; pin setup-php; add --no-scripts
.github/workflows/phpunit-pgsql.yml Migrate to org template; PR-only trigger; update Postgres image; pin setup-php; add --no-scripts
.github/workflows/phpunit-oci.yml Migrate to org template; PR-only trigger; pin setup-php; add --no-scripts
.github/workflows/phpunit-mysql.yml Migrate to org template; PR-only trigger; pin setup-php; add --no-scripts
.github/workflows/lint-stylelint.yml Migrate to org template; PR-only trigger; update SPDX header license
.github/workflows/lint-php.yml Migrate to org template; PR-only trigger; add permissions, concurrency, matrix
.github/workflows/lint-php-cs.yml Migrate to org template; PR-only trigger; add permissions, concurrency, dynamic PHP versions
.github/workflows/lint-info-xml.yml Migrate to org template; PR-only trigger; update SPDX header license
.github/workflows/lint-eslint.yml Migrate to org template; PR-only trigger; update setup-node version
Comments suppressed due to low confidence (4)

.github/workflows/phpunit-sqlite.yml:124

  • [nitpick] Adding --no-scripts will skip all Composer scripts, which may include cleanup or autoload generation needed by Nextcloud. Verify that skipping scripts doesn’t break the test setup, or consider running only the specific scripts you want to skip.
          composer remove nextcloud/ocp --dev --no-scripts

.github/workflows/reuse.yml:12

  • [nitpick] The push trigger was removed, so REUSE checks will no longer run on direct pushes to main. Confirm that running only on pull requests matches your policy for compliance enforcement.
on: [pull_request]

.github/workflows/phpunit-pgsql.yml:81

  • Using :latest can lead to non-reproducible CI runs if the image is updated. Consider pinning to a specific version or digest for consistent test environments.
        image: ghcr.io/nextcloud/continuous-integration-postgres-16:latest # zizmor: ignore[unpinned-images]

.github/workflows/lint-php-cs.yml:36

  • [nitpick] There's no space between php and the version variable in the step name, which may reduce readability. Consider renaming to Set up php ${{ steps.versions.outputs.php-min }}.
      - name: Set up php${{ steps.versions.outputs.php-min }}

@printminion-co printminion-co merged commit cbba841 into main Jul 9, 2025
34 checks passed
@printminion-co printminion-co deleted the mk/dev/update_workflows branch July 9, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants