Skip to content

Conversation

@printminion-co
Copy link
Contributor

@printminion-co printminion-co commented Aug 5, 2025

run:

./themes/nc-ionos-theme/.github/scripts/generate_core_patches.sh

it will generate:

  • 0001-fix-Fix-truncation-on-public-shares.patch
  • 0002-chore-Add-SPDX-header.patch
  • 0003-chore-Add-SPDX-header.patch
  • 0004-refactorcore-Make-AJAX-cron-script-work-without-jQuery.patch
  • 0005-fixstyles-Make-sure-footer-with-legal-links-is-shown-correctly.patch
  • 0006-chorecore-wrap-initial-state-into-hidden-container.patch
  • 0007-feat-Provide-CSP-nonce-as-meta-element.patch
  • 0008-fix-Disable-auto-zoom-on-iOS.patch
  • 0009-fix-Disable-auto-zoom-on-iOS.patch
  • 0010-Fix-float-and-clear.patch
  • 0011-chore-Remove-legacy-JS-code-for-public-page-menu-header-actions.patch
  • 0012-refactorIMenuAction-Make-public-menu-actions-use-the-new-Vue-UI.patch
  • 0013-choredeps-Update-nextcloudcoding-standard-to-v131.patch
  • 0014-featrtl-Set-layout-direction-based-on-language.patch
  • 0015-featfilessharing-use-share-node-or-label-as-page-title.patch
  • 0016-fix-Apply-enforce-theme-config-for-anonymous-users-as-well.patch
  • 0017-fixtemplate-Use-div-instead-of-main-to-support-Vue3-apps-mounting.patch
  • 0018-fixcore-Fix-undefined-application-array-key-error.patch
  • 0019-fixcore-Fix-undefined-application-array-key-error-in-user-layout.patch
  • 0020-fixtheming-enforce-theme-also-for-login.patch

(cherry picked from commit nextcloud/server@9546f4c)
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@885ec73)
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
This way we use the CSP nonce for dynamically loaded scripts.
Important to notice: The CSP nonce must NOT be injected in `content` as
this can lead to value exfiltration using e.g. side-channel attacts (CSS selectors).

(cherry picked from commit nextcloud/server@2916e5d)
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
When using iOS and focussing an input element the view should not be zoomed.
So if we set a maximum scale iOS will not auto-zoom but still allow users to zoom.
But we can not do this by default as this will disable user zoom on Chrome.

(cherry picked from commit nextcloud/server@ec00367)
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
This removes custom rendering code an replaces it with the declarative menu actions.
Also adjust the template to allow the Vue UI to mount.
Custom entries still are possible.

(cherry picked from commit nextcloud/server@4d2556d)
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@9836e9b)
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@2b7efd6)
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@4d9d617)
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@438528b)
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…ounting

Vue3 does not replace the element while mounting but only renders within
(replace inner HTML).
So it would result in two stacked `<main>` elements which is invalid and
an accessibility issue.
Instead we just use a `<div>` element for mounting.

For Vue2 apps this does not change anything as the whole element will be
replaced with a new `<main>` element.
For vanilla apps this will slightly decrease the accessibility as the
main landmark is now missing, but this is not a hard accessibility issue
as it would be for Vue3 apps having two main elements.

(cherry picked from commit nextcloud/server@182acb1)
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@8bd93f5)
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@be2f75e)
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
@printminion-co printminion-co changed the title patch to v31 v2 patch to v31 Aug 5, 2025
Copy link
Collaborator

@bromiesTM bromiesTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also have a look at
IONOS-Productivity/nc-theming#91
too and include it into the submodule update to fix the default appearance of the download button

@printminion-co printminion-co merged commit 99edb61 into main Aug 7, 2025
@printminion-co printminion-co deleted the mk/dev/patch_to_v31-v2 branch August 7, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants