-
Notifications
You must be signed in to change notification settings - Fork 0
patch to v31 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
patch to v31 #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@9546f4c) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@39e163a) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@885ec73) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
This way we use the CSP nonce for dynamically loaded scripts. Important to notice: The CSP nonce must NOT be injected in `content` as this can lead to value exfiltration using e.g. side-channel attacts (CSS selectors). (cherry picked from commit nextcloud/server@2916e5d) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
When using iOS and focussing an input element the view should not be zoomed. So if we set a maximum scale iOS will not auto-zoom but still allow users to zoom. But we can not do this by default as this will disable user zoom on Chrome. (cherry picked from commit nextcloud/server@ec00367) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@7b6c78c) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
This removes custom rendering code an replaces it with the declarative menu actions. Also adjust the template to allow the Vue UI to mount. Custom entries still are possible. (cherry picked from commit nextcloud/server@4d2556d) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@9836e9b) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@2b7efd6) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@4d9d617) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@438528b) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…ounting Vue3 does not replace the element while mounting but only renders within (replace inner HTML). So it would result in two stacked `<main>` elements which is invalid and an accessibility issue. Instead we just use a `<div>` element for mounting. For Vue2 apps this does not change anything as the whole element will be replaced with a new `<main>` element. For vanilla apps this will slightly decrease the accessibility as the main landmark is now missing, but this is not a hard accessibility issue as it would be for Vue3 apps having two main elements. (cherry picked from commit nextcloud/server@182acb1) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@8bd93f5) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@74d2601) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
(cherry picked from commit nextcloud/server@be2f75e) Signed-off-by: Misha M.-Kupriyanov <[email protected]>
6 tasks
bromiesTM
approved these changes
Aug 7, 2025
Collaborator
bromiesTM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also have a look at
IONOS-Productivity/nc-theming#91
too and include it into the submodule update to fix the default appearance of the download button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run:
it will generate: