Ionos dev v8.22.0

.github/workflows/node-test.yml

@@ -88,7 +88,7 @@ jobs:
         run: npm run test:coverage --if-present
 
       - name: Collect coverage
-        uses: codecov/codecov-action@015f24e6818733317a2da2edd6290ab26238649a # v5.0.7
+        uses: codecov/codecov-action@1e68e06f1dbfde0e4cefc87efeba9e4643565303 # v5.1.2
         with:
           files: ./coverage/lcov.info
 

CHANGELOG.md

@@ -5,6 +5,56 @@
 
 # Changelog
 
+## [v8.22.0](https://github.com/nextcloud-libraries/nextcloud-vue/tree/v8.22.0) (2024-12-20)
+[Full Changelog](https://github.com/nextcloud-libraries/nextcloud-vue/compare/v8.21.0...v8.22.0)
+
+### 🚀 Enhancements
+* feat(NcAvatar): implement custom javascript hook action for the contacts menu [\#6238](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6238) \([st3iny](https://github.com/st3iny)\)
+* feat(NcAppNavigation): add `n` hotkey to toggle navigation [\#6311](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6311) \([skjnldsv](https://github.com/skjnldsv)\)
+### 🐛 Fixed bugs
+* fix(NcAppNavigationItem): TypeError: this.$refs.actions.$refs.menuButton is undefined [\#6226](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6226) \([wofferl](https://github.com/wofferl)\)
+* fix(NcListItem): Don't require name prop by @artonge in [\#6128](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6128) \([artonge](https://github.com/artonge)\)
+* style(NcCheckboxRadioSwitch): fix styles in disabled state [\#6265](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6265) \([Antreesy](https://github.com/Antreesy)\)
+* fix(NcModal): make 'Close' button the last element for the focus-trap [\#6266](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6266) \([Antreesy](https://github.com/Antreesy)\)
+* fix(NcAppNavigation): Fix sidebar position in RTL and mobile mode.[\#6260](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6260) \([falghamdi125](https://github.com/falghamdi125)\)
+* fix(NcAppContent): add RTL support [\#6303](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6303) \([hamza221](https://github.com/hamza221)\)
+* fix(NcCheckboxRadioSwitch): RTL support [\#6302](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6302) \([hamza221](https://github.com/hamza221)\)
+* fix(NcDateTimePicker): popup position [\#6312](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6312) \([hamza221](https://github.com/hamza221)\)
+* Fix(NcSettingsSection): Add RTL support to NcSettingsSection info icon. [\#6290](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6290) \([falghamdi125](https://github.com/falghamdi125)\)
+* Fix(NcDashboardWidgetItem): Add RTL support to NcDashboardWidgetItem [\#6292](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6292) \([falghamdi125](https://github.com/falghamdi125)\)
+* fix(useHotKey): allow hotkeys with implicit `SHIFT` and add `caseSensitive`, custom event filter options [\#6301](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6301) \([Antreesy](https://github.com/Antreesy)\)
+* fix(NcRichContenteditable): prevent content from overflowing [\#6316](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6316) \([Antreesy](https://github.com/Antreesy)\)
+* fix(NcActionButton): RTL support [\#6200](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6200) \([falghamdi125](https://github.com/falghamdi125)\)
+### Changed
+* docs(NcDateTimePickerNative): add time picker example [\#6188](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6188) \([GVodyanov](https://github.com/GVodyanov)\)
+* chore(NcAppSidebarTabs): remove internal component from docs [\#6253](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6253) \([ShGKme](https://github.com/ShGKme)\)
+* Updated workflows and dependencies
+* Updated translations
+
+## New Contributors
+* @falghamdi125 made their first contribution in https://github.com/nextcloud-libraries/nextcloud-vue/pull/6260
+
+## [v8.21.0](https://github.com/nextcloud-libraries/nextcloud-vue/tree/v8.21.0) (2024-11-21)
+[Full Changelog](https://github.com/nextcloud-libraries/nextcloud-vue/compare/v8.20.0...v8.21.0)
+
+
+### 🚀 Enhancements
+* feat(NcRichText): highlight code syntax if language provided [\#6212](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6212) \([Antreesy](https://github.com/Antreesy)\)
+
+### 🐛 Fixed bugs
+* fix(NcInputField): correct position of trailing icon in RTL [\#6202](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6202) \([alsulami1](https://github.com/alsulami1)\)
+* fix(NcChip): wrong color-primary-text variable used [\#6218](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6218) \([skjnldsv](https://github.com/skjnldsv)\)
+* fix: make sure model event in `v-model` happens first to avoid regression [\#6234](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6234) \([ShGKme](https://github.com/ShGKme)\)
+* fix(NcTextField): don't fire value-updating events twice [\#6235](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6235) \([ShGKme](https://github.com/ShGKme)\)
+* fix(NcRichContenteditable): support mentions of email/* guests [\#6233](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6233) \([Antreesy](https://github.com/Antreesy)\)
+* fix(NcAppContent): correct splitter color in dark mode when using split-horizontal mode [\#6227](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6227) \([wofferl](https://github.com/wofferl)\)
+* fix(NcRichContenteditable): do not break adjacent user mentions [\#6223](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6223) \([Antreesy](https://github.com/Antreesy)\)
+* fix(NcRichContenteditable): fix pasting of the content to an empty field [\#6241](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6241) \([DorraJaouad](https://github.com/DorraJaouad)\)
+
+## New Contributors
+* @alsulami1 made their first contribution in [\#6202](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6202)
+* @wofferl made their first contribution in [\#6227](https://github.com/nextcloud-libraries/nextcloud-vue/pull/6227)
+
 ## [v8.20.0](https://github.com/nextcloud-libraries/nextcloud-vue/tree/v8.20.0) (2024-10-29)
 [Full Changelog](https://github.com/nextcloud-libraries/nextcloud-vue/compare/v8.19.0...v8.20.0)
 

cypress/component/NcAppNavigation.cy.ts

@@ -0,0 +1,82 @@
+/**
+ * SPDX-FileCopyrightText: Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+import NcAppNavigation from '../../src/components/NcAppNavigation/NcAppNavigation.vue'
+import NcAppNavigationItem from '../../src/components/NcAppNavigationItem/NcAppNavigationItem.vue'
+
+describe('NcAppNavigation hotkeys', () => {
+	it('opens on n keyboard press', () => {
+		cy.mount({
+			render: (h) => h(NcAppNavigation, {
+				scopedSlots: {
+					list: () => [
+						h(NcAppNavigationItem, { props: { name: 'First' } }),
+					],
+				},
+			}),
+		})
+
+		cy.contains('li', 'First').should('exist')
+
+		cy.get('nav').then(($nav) => {
+			const id = $nav.attr('id')
+			cy.get(`[aria-controls="${id}"`).as('appNavigationToggle')
+			cy.get('@appNavigationToggle').should('have.attr', 'aria-expanded', 'true')
+			cy.get('nav').should('have.attr', 'aria-hidden', 'false')
+			cy.get('nav').should('not.have.attr', 'inert')
+
+			// close the sidebar
+			cy.get('@appNavigationToggle').click()
+
+			cy.get('@appNavigationToggle').should('have.attr', 'aria-expanded', 'false')
+			cy.get('nav').should('have.attr', 'aria-hidden', 'true')
+			cy.get('nav').should('have.attr', 'inert')
+
+			// open the sidebar with the keyboard
+			cy.get('body').type('n')
+
+			cy.get('@appNavigationToggle').should('have.attr', 'aria-expanded', 'true')
+			cy.get('nav').should('have.attr', 'aria-hidden', 'false')
+			cy.get('nav').should('not.have.attr', 'inert')
+
+			// make sure we auto-focus the first item
+			cy.document().then((doc) => {
+				const activeElement = doc.activeElement
+				const navigation = doc.querySelector('nav')
+				// eslint-disable-next-line no-unused-expressions
+				expect(navigation?.contains(activeElement)).to.be.true
+			})
+		})
+	})
+
+	it('closes on n keyboard press', () => {
+		cy.mount({
+			render: (h) => h(NcAppNavigation, {
+				scopedSlots: {
+					list: () => [
+						h(NcAppNavigationItem, { props: { name: 'First' } }),
+					],
+				},
+			}),
+		})
+
+		cy.contains('li', 'First').should('exist')
+		cy.get('nav').should('have.attr', 'aria-hidden', 'false')
+		cy.get('nav').should('not.have.attr', 'inert')
+
+		// pressing n does nothing until we focus something within
+		cy.get('body').type('n')
+		cy.get('nav').should('have.attr', 'aria-hidden', 'false')
+		cy.get('nav').should('not.have.attr', 'inert')
+
+		// focus something within
+		cy.get('nav').find('a').first().focus()
+
+		// pressing n closes the sidebar
+		cy.get('body').type('n')
+		cy.get('nav').should('have.attr', 'aria-hidden', 'true')
+		cy.get('nav').should('have.attr', 'inert')
+	})
+})

docs/composables/useHotKey.md

@@ -13,17 +13,22 @@ import { useHotKey } from '@nextcloud/vue/dist/Composables/useHotKey/index.js'
 const stopCallback = useHotKey(key, callback, options)
 ```
 where:
-- `key`: string representing the keyboard key to listen to
+- `keysOrFilter`: one of following:
+  - `string`: representing the keyboard key to listen to
+  - `Array<string>`: representing any of keys to listen to
+  - `Function`: custom filter function to validate event key
+  - `true`: to listen for all events
 
-	See [KeyboardEvent.key Value column](https://developer.mozilla.org/en-US/docs/Web/API/UI_Events/Keyboard_event_key_values) for possible values
+  See [KeyboardEvent.key Value column](https://developer.mozilla.org/en-US/docs/Web/API/UI_Events/Keyboard_event_key_values) for possible values
 - `callback`: a function to be called when the key is pressed. Before called, it will be checked whether keyboard shortcuts are disabled, or interactive element is currently focused, or whether options should be applied
 - `options`: options to be applied to the shortcut:
-  - `push`: whether the event should be triggered on both keydown and keyup
-  - `prevent`: prevents the default action of the event
-  - `stop`: prevents propagation of the event in the capturing and bubbling phases
-  - `ctrl`: whether the Ctrl key should be pressed (Cmd key on MacOS)
-  - `alt`: whether the Alt key should be pressed
-  - `shift`: whether the Shift key should be pressed
+  - `push`: whether the event should be triggered on both keydown and keyup (default: `false`)
+  - `prevent`: prevents the default action of the event (default: `false`)
+  - `stop`: prevents propagation of the event in the capturing and bubbling phases (default: `false`)
+  - `ctrl`: whether the Ctrl key (Cmd key on MacOS) should be pressed (default: `false`)
+  - `alt`: whether the Alt key should be pressed (default: `false`)
+  - `shift`: whether the Shift key should be pressed (should be explicitly defined as `true`|`false` if needed)
+  - `caseSensitive`: whether specific case should be listened, e.g. only 'd' and not 'D' (default: `false`)
 - `stopCallback`: a callback to stop listening to the event
 
 ### Playground

l10n/ar.pot

@@ -1,13 +1,13 @@
 # 
 # Translators:
-# John Molakvoæ <[email protected]>, 2023
 # Hamza, 2024
 # Ali <[email protected]>, 2024
-# abusaud, 2024
+# abu.s3ud, 2024
+# John Molakvoæ <[email protected]>, 2024
 # 
 msgid ""
 msgstr ""
-"Last-Translator: abusaud, 2024\n"
+"Last-Translator: John Molakvoæ <[email protected]>, 2024\n"
 "Language-Team: Arabic (https://app.transifex.com/nextcloud/teams/64236/ar/)\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Language: ar\n"
@@ -32,9 +32,6 @@ msgstr "بازلائي مطفي"
 msgid "Actions"
 msgstr "إجراءات"
 
-msgid "Actions for item with name \"{name}\""
-msgstr "إجراءات على العنصر المُسمَّى \"{name}\""
-
 msgid "Activities"
 msgstr "سجل الأنشطة"
 
@@ -272,8 +269,8 @@ msgstr "إفتَح الرابط إلى \"{resourceName}\""
 msgid "Open menu"
 msgstr "إفتَح القائمة"
 
-msgid "Open navigation"
-msgstr "إفتَح المتصفح"
+msgid "Open navigation {shortcut}"
+msgstr "إفتَح المتصفح {shortcut}"
 
 msgid "Open sidebar"
 msgstr "إفتَح الشريط الجانبي"

l10n/cs.pot

@@ -29,9 +29,6 @@ msgstr "Akapulko"
 msgid "Actions"
 msgstr "Akce"
 
-msgid "Actions for item with name \"{name}\""
-msgstr "Akce pro položku s názvem „{name}“"
-
 msgid "Activities"
 msgstr "Aktivity"
 
@@ -269,8 +266,8 @@ msgstr "Otevřít odkaz na „{resourceName}“"
 msgid "Open menu"
 msgstr "Otevřít nabídku"
 
-msgid "Open navigation"
-msgstr "Otevřít navigaci"
+msgid "Open navigation {shortcut}"
+msgstr "Otevřít navigaci {shortcut}"
 
 msgid "Open sidebar"
 msgstr "Otevřít postranní panel"

l10n/da.pot

@@ -1,13 +1,13 @@
 # 
 # Translators:
-# John Molakvoæ <[email protected]>, 2023
 # Martin "phnoggie" Trads, 2023
 # Rasmus Rosendahl-Kaa, 2024
 # Martin Bonde <[email protected]>, 2024
+# John Molakvoæ <[email protected]>, 2024
 # 
 msgid ""
 msgstr ""
-"Last-Translator: Martin Bonde <[email protected]>, 2024\n"
+"Last-Translator: John Molakvoæ <[email protected]>, 2024\n"
 "Language-Team: Danish (https://app.transifex.com/nextcloud/teams/64236/da/)\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Language: da\n"
@@ -32,9 +32,6 @@ msgstr "Acapulco"
 msgid "Actions"
 msgstr "Handlinger"
 
-msgid "Actions for item with name \"{name}\""
-msgstr "Handlinger for element med navnet \"{name}\""
-
 msgid "Activities"
 msgstr "Aktiviteter"
 
@@ -272,8 +269,8 @@ msgstr "Åbn link til \"{resourceName}\""
 msgid "Open menu"
 msgstr "Åben menu"
 
-msgid "Open navigation"
-msgstr "Åbn navigation"
+msgid "Open navigation {shortcut}"
+msgstr "Åbn navigation {shortcut}"
 
 msgid "Open sidebar"
 msgstr "Åbn sidepanel"

l10n/de.pot

@@ -33,9 +33,6 @@ msgstr "Acapulco"
 msgid "Actions"
 msgstr "Aktionen"
 
-msgid "Actions for item with name \"{name}\""
-msgstr "Aktionen für das Element \"{name}“"
-
 msgid "Activities"
 msgstr "Aktivitäten"
 
@@ -275,8 +272,8 @@ msgstr "Link zu \"{resourceName}“ öffnen"
 msgid "Open menu"
 msgstr "Menü öffnen"
 
-msgid "Open navigation"
-msgstr "Navigation öffnen"
+msgid "Open navigation {shortcut}"
+msgstr "Navigation öffnen {shortcut}"
 
 msgid "Open sidebar"
 msgstr "Seitenleiste öffnen"

l10n/de_DE.pot

@@ -32,9 +32,6 @@ msgstr "Acapulco"
 msgid "Actions"
 msgstr "Aktionen"
 
-msgid "Actions for item with name \"{name}\""
-msgstr "Aktionen für Element mit dem Namen \"{name}“"
-
 msgid "Activities"
 msgstr "Aktivitäten"
 
@@ -274,8 +271,8 @@ msgstr "Link zu \"{resourceName}“ öffnen"
 msgid "Open menu"
 msgstr "Menü öffnen"
 
-msgid "Open navigation"
-msgstr "Navigation öffnen"
+msgid "Open navigation {shortcut}"
+msgstr "Navigation öffnen {shortcut}"
 
 msgid "Open sidebar"
 msgstr "Seitenleiste öffnen"

l10n/en_GB.pot

@@ -1,11 +1,11 @@
 # 
 # Translators:
-# John Molakvoæ <[email protected]>, 2023
 # Andi Chandler <[email protected]>, 2024
+# John Molakvoæ <[email protected]>, 2024
 # 
 msgid ""
 msgstr ""
-"Last-Translator: Andi Chandler <andi@gowling.com>, 2024\n"
+"Last-Translator: John Molakvoæ <skjnldsv@protonmail.com>, 2024\n"
 "Language-Team: English (United Kingdom) (https://app.transifex.com/nextcloud/teams/64236/en_GB/)\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Language: en_GB\n"
@@ -30,9 +30,6 @@ msgstr "Acapulco"
 msgid "Actions"
 msgstr "Actions"
 
-msgid "Actions for item with name \"{name}\""
-msgstr "Actions for item with name \"{name}\""
-
 msgid "Activities"
 msgstr "Activities"
 
@@ -270,8 +267,8 @@ msgstr "Open link to \"{resourceName}\""
 msgid "Open menu"
 msgstr "Open menu"
 
-msgid "Open navigation"
-msgstr "Open navigation"
+msgid "Open navigation {shortcut}"
+msgstr "Open navigation {shortcut}"
 
 msgid "Open sidebar"
 msgstr "Open sidebar"

l10n/fa.pot

@@ -31,9 +31,6 @@ msgstr "آکاپولکو"
 msgid "Actions"
 msgstr "کنش‌ها"
 
-msgid "Actions for item with name \"{name}\""
-msgstr "کنش‌ها برای موردی با نام «{name}»"
-
 msgid "Activities"
 msgstr "فعالیت‌ها"
 

l10n/fi.pot

@@ -30,9 +30,6 @@ msgstr "Acapulco"
 msgid "Actions"
 msgstr "Toiminnot"
 
-msgid "Actions for item with name \"{name}\""
-msgstr "\"{name}\"n toiminnot"
-
 msgid "Activities"
 msgstr "Aktiviteetit"