Skip to content

IONOS(Movie): Thumbnail: prevent downloading large files from non-loc… #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
printminion-co merged 1 commit into from
Apr 9, 2025
Merged

IONOS(Movie): Thumbnail: prevent downloading large files from non-loc… #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/private/Preview/Movie.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@ public function getThumbnail(File $file, int $maxX, int $maxY): ?IImage {
// in some cases this doesn't work for example when the moov atom is at the
// end of the file, so if it fails we fall back to getting the full file
$sizeAttempts = [5242880, null];

// do not attempt to download the file if the storage is not local (e.g. S3)
// We don't want to download the whole (e.g. 37Gb) file
if (!$file->getStorage()->isLocal()) {
$sizeAttempts = [5242880];
}
} else {
// size is irrelevant, only attempt once
$sizeAttempts = [null];
Expand Down
Loading