redirect upgradepage #155
Draft
redirect upgradepage #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
printminion-co
force-pushed
the
mk/dev/redirect_upgradepage
branch
from
ab5c202 to
c9a4519
Compare
bromiesTM
requested changes
Apr 14, 2025
lib/base.php
Outdated
| if ($redirectUpgradePage !== null) { | ||
| http_response_code(307); | ||
| header('X-Nextcloud-needsDbUpgrade: 1'); | ||
| header("Location: ${redirectUpgradePage}#" . time()); |
There was a problem hiding this comment.
I imagine it would be a good idea to check if redirect_upgradepage_to_location is a valid string
printminion-co
force-pushed
the
mk/dev/redirect_upgradepage
branch
from
7f38259 to
7291a6c
Compare
printminion-co
force-pushed
the
mk/dev/redirect_upgradepage
branch
from
7291a6c to
ca4fce4
Compare
in case you dont want to display upgrade button to users you can redirect them to other location (e.g. dedicated maintenance page) set desired location via ./occ config:system:set --type string --value /maintenance -- upgrade.redirect_upgradepage_to_location Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
force-pushed
the
mk/dev/redirect_upgradepage
branch
from
ca4fce4 to
ae5864e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case you dont want to display upgrade button to users
you can redirect them to other location (e.g. dedicated maintenance page)
set desired location via
./occ config:system:set --type string --value /maintenance -- upgrade.redirect_upgradepage_to_locationTEST
./occ maintenance:mode --offtruegit checkout ionos-dev-v30.0.5and then switch togit checkout ionos-dev-v30.0.7branch./occ config:system:set --type string --value /maintenance -- upgrade.redirect_upgradepage_to_locationcurl -i http://localhost:8080/index.php/maitenence#<timestamp>