Skip to content

Conversation

@thlehmann-ionos
Copy link

@thlehmann-ionos thlehmann-ionos commented Oct 21, 2024

use #59 instead

The app implements sending share create mails to our internal mail service.

Build

apps-custom/nc_ionos_processes $ composer install

App-Install

$ ./occ app:enable nc_ionos_processes

Copy link

@bromiesTM bromiesTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submodule commit is outdated and for example still features some mentions of nc_theming in the composer.json. We should update it to the latest version of the initial commit :))

@bromiesTM
Copy link

Is this app supposed to be activated via occ or via our config scripts?

@thlehmann-ionos thlehmann-ionos force-pushed the tl/dev/add-ionos-processes-app branch from c00b189 to bb765d3 Compare October 22, 2024 09:11
@thlehmann-ionos
Copy link
Author

The submodule commit is outdated and for example still features some mentions of nc_theming in the composer.json. We should update it to the latest version of the initial commit :))

Updated.

Is this app supposed to be activated via occ or via our config scripts?

Our config scripts will automatically enable all apps in custom-apps. For development, when switching branches. occ app enable nc_ionos_processes is the way to go.

@thlehmann-ionos thlehmann-ionos force-pushed the tl/dev/add-ionos-processes-app branch from bb765d3 to a02c486 Compare October 24, 2024 17:00
Copy link

@printminion-co printminion-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review ok

@printminion-co printminion-co force-pushed the tl/dev/add-ionos-processes-app branch from a02c486 to 7248412 Compare October 28, 2024 10:55
@printminion-co
Copy link

upgraded to latest config a02c486...7248412 tl/dev/add-ionos-processes-app

@printminion-co printminion-co force-pushed the tl/dev/add-ionos-processes-app branch 2 times, most recently from 8721776 to 8e455eb Compare October 30, 2024 08:50
@printminion-co printminion-co changed the title IONOS(feat): add ionos_processes custom app WIP IONOS(feat): add ionos_processes custom app Oct 30, 2024
@github-actions
Copy link

github-actions bot commented Nov 5, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@printminion-co printminion-co force-pushed the tl/dev/add-ionos-processes-app branch from 8e455eb to 2457e9f Compare November 11, 2024 10:23
@bromiesTM bromiesTM force-pushed the tl/dev/add-ionos-processes-app branch from 2457e9f to 5307033 Compare November 13, 2024 15:00
@printminion-co printminion-co force-pushed the tl/dev/add-ionos-processes-app branch from 5307033 to a471cba Compare November 15, 2024 16:03
@printminion-co printminion-co marked this pull request as draft November 29, 2024 14:45
@printminion-co
Copy link

already implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants