Skip to content

Conversation

@printminion-co
Copy link

@printminion-co printminion-co commented Jan 23, 2025

Summary

Review and merge dependencies

TODO

  • review and merge dependencies
  • update submodule pointers of
  • serverinfo
  • viewer
  • nc-vue-material-design-icons
  • nc-nextcloud-vue
  • check for legacy template changes (since we just copied thee files)

rebase log

git fetch --all --tags
git checkout stable30
git reset --hard ionos/stable30

checkout tag as branch

git checkout tags/v30.0.5 -b nextcloud-v30.0.5

checkout ionos-dev

git switch ionos-dev
git reset --hard ionos/ionos-dev
create branch for rebase
git checkout -b ionos/rebase/ionos-dev-v30.0.5
git push origin ionos/rebase/ionos-dev-v30.0.5

rebase onto nextcloud-v30.0.5

  • 65648889 is the hash of the last commit before our changes
git rebase --onto nextcloud-v30.0.5 65648889

resolve conflicts

  • REBASE 46/155
    • IONOS: feat(files_sharing): confirm share deletion
      • ShareMixin.js -resolve conflicts
      • git rebase --continue
  • REBASE 82/155
    • IONOS(nc-vue-icons): add nc-vue-material-design-icons as submodule
      • package-lock.json git restore --staged package-lock.json && npm i --package-lock-only && git add package-lock.json
      • git rebase --continue
  • REBASE 105/155
    • IONOS(nc-mdi-svg): add nc-MaterialDesign-SVG as submodule
      • package-lock.json
        • copy .npmrc from nc-mdi-svg
        • git restore --staged package-lock.json && npm i --package-lock-only && git add package-lock.json
        • git rebase --continue
  • REBASE 107/155
    • IONOS(nc-mdi-svg): use custom nc-MaterialDesign-SVG dist
      • package-lock.json
        • git restore --staged package-lock.json && npm i --package-lock-only && git add package-lock.json
        • git rebase --continue
  • REBASE 109/155
    • IONOS(build): switch to custom mdi icons
    • package-lock.json
      • git restore --staged package-lock.json && npm i --package-lock-only && git add package-lock.json
      • git rebase --continue
  • REBASE 116/155
    • IONOS(build): switch to custom nextcloud vue
      • package.json - resolve conflict
      • package-lock.json
        • git restore --staged package-lock.json && npm i --package-lock-only && git add package-lock.json
        • git rebase --continue
  • REBASE 117/155
    • IONOS(build): remove original "@mdi/js", "@mdi/svg", vue-material-design-icons" dependencies
      • package.json - resolve conflict
      • package-lock.json
        • git restore --staged package-lock.json && npm i --package-lock-only && git add package-lock.json
        • git rebase --continue

Notes

  • package-lock.json - should not contain "@fortawesome/*"

@printminion-co printminion-co marked this pull request as draft January 23, 2025 14:48
@printminion-co printminion-co marked this pull request as ready for review January 24, 2025 15:47
printminion-co and others added 27 commits January 27, 2025 15:35
Closes: HDFRONT-6801

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Closes: HDFRONT-6655/HDFRONT-6801

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
in order to be able to build/deploy dev state

Closes: HDFRONT-6801

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Although not used yet let's take this naming convention to have app
directories nearby.
Subsequent container build scripts will need it.
We will maintain our additional and custom apps in these directories.

Closes: HDFRONT-6832
To ensure these directories exist

Closes: HDFRONT-6832
At current stable29 *branch*

Command:

   $ git submodule add https://github.com/nextcloud/viewer.git apps-external/viewer/
This is a submodules, but other apps will be installed via download.
Changes there:

* install script for user_oidc
* shellcheck for the repo

Closes: HDFRONT-6832
The "redirects" config allows configuring redirects from paths to routes.

Example config:

   "redirects" => { "^/path/regexp" => "an.apps.controller.route.locator" }

Use case:

* An administrator can configure another app as target for certain paths.

Differentiation from Apache redirects:

* this allows configuring redirects in one place and avoids spreading
  the configuration in multiple places.

* the target route locator is more expressive/easier to trace than a
  path

Signed-off-by: Thomas Lehmann <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
simplesettings

The config for the previously added "redirects" feature.

Signed-off-by: Thomas Lehmann <[email protected]>
* Fixed missing routes for wiping devices
* Fix missing package which prevents from-scratch build

Signed-off-by: Thomas Lehmann <[email protected]>
Latest changes:

* app install / enable refactoring
* enabling apps

Signed-off-by: Thomas Lehmann <[email protected]>
Actually required for the custom and external apps. Since the
workflow starts in the project root, it initially "sees" the
Nextcloud package.json.

Since entering each app directory and setting up different Node/npm
versions is no feasible anyway, let's set it here.

Signed-off-by: Thomas Lehmann <[email protected]>
To track it as submodule in version control

Signed-off-by: Thomas Lehmann <[email protected]>
Exclude node_modules, tests and GitHub/Gut dirs too.

Signed-off-by: Thomas Lehmann <[email protected]>
…pps-external/

Build simplesettings (custom) and user_oidc (external)

Signed-off-by: Thomas Lehmann <[email protected]>
* Enable custom apps too
* user_oidc will no longer be downloaded

Signed-off-by: Thomas Lehmann <[email protected]>
Fix missing package which prevents from-scratch build (updated amended
commit)

Signed-off-by: Thomas Lehmann <[email protected]>
fracado and others added 22 commits January 27, 2025 16:23
As long as translations for these keys aren't provided from 'files' translations, we need this workaround to provide the translations via the 'core' themes app.

Signed-off-by: Franziska Bath <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…sktop, tablet, mobile)

Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
git submodule add [email protected]:nextcloud/serverinfo.git apps-external/serverinfo

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
in order to have latest v30 release version

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
@printminion-co printminion-co force-pushed the ionos/rebase/ionos-dev-v30.0.5 branch from fe94337 to 7de626b Compare January 27, 2025 15:28
@printminion-co printminion-co force-pushed the ionos/rebase/ionos-dev-v30.0.5 branch from 44d6c8f to 288a30e Compare January 28, 2025 15:38
Copy link

@bromiesTM bromiesTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there also is a issue with styling of mimetype icons and the filename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants