WIP: feat(Application.php): load in-folder-search from files app #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Henseler <[email protected]>
printminion-co
force-pushed
the
kh/dev/places-search-broken-in-settings
branch
from
47e81d2 to
778c56a
Compare
printminion-co
approved these changes
Jun 12, 2025
Contributor
printminion-co
left a comment
printminion-co
left a comment
There was a problem hiding this comment.
probably not the bes way to do it.. ..we will ask NC to implement it in core and remove it in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be a silly way but the search plugin of the files app
folderSearch.tsis loaded for the files app and standard settings but not our custom app. The Style was in fact not wrong but the search was missing a plugin