upgrade codebase #97
Merged
upgrade codebase #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
printminion-co
force-pushed
the
mk/dev/upgrade_codebase
branch
3 times, most recently
from
e98cc26 to
8dd3678
Compare
printminion-co
force-pushed
the
mk/dev/upgrade_codebase
branch
from
8dd3678 to
857e8d7
Compare
printminion-co
force-pushed
the
mk/dev/upgrade_codebase
branch
from
857e8d7 to
4264841
Compare
printminion-co
force-pushed
the
mk/dev/upgrade_codebase
branch
2 times, most recently
from
70a340e to
13c9a0b
Compare
in order to be consistent with property name for later optimisation Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…d clarity OC_Helper is deprecated Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…mproved dependency injection since we extend the Constructor class Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
force-pushed
the
mk/dev/upgrade_codebase
branch
from
13c9a0b to
e2b35ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.