Skip to content

Conversation

@tanyaka
Copy link
Contributor

@tanyaka tanyaka commented Dec 13, 2024

No description provided.

Copy link
Contributor

@fracado fracado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

When selecting a file or folder, the position of the overlaying table headers is slightly wrong, both in list and grid view. My suggestion should fix this issue.

css/files.css Outdated
Comment on lines 5 to 7
.files-list__thead{
top: 0;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.files-list__thead{
top: 0;
}
.files-list__thead, .files-list__thead-overlay {
top: 0;
}

This should fix the wrongly positioned table header when a file or folder is selected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you finding! Proposal adopted.

Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
@tanyaka tanyaka force-pushed the tkl/dev/hide-filefilters branch from 60559e6 to e18eb8e Compare December 17, 2024 09:35
Copy link
Contributor

@fracado fracado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review OK.

@tanyaka tanyaka merged commit c96285c into main Dec 17, 2024
1 of 7 checks passed
@tanyaka tanyaka deleted the tkl/dev/hide-filefilters branch December 17, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants