-
Notifications
You must be signed in to change notification settings - Fork 0
Tkl/dev/layout #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tkl/dev/layout #29
Conversation
f6fa30b to
5d61dba
Compare
fracado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be no need for a --list-row-height variable. Simply changing the --row-height variable seems to work fine.
Adjustment for breadcrumb on mobile is missing.
Also, the positioning of the icon for the table header for "size" needs to be adjusted.
See review branch: tkl/dev/layout...fb/review/layout
Changes in PR IONOS-Productivity/nc-server#78 don't seem to be needed and commits (apart from the submodule update) can be dropped.
… button Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
Signed-off-by: Franziska Bath <[email protected]>
Signed-off-by: Franziska Bath <[email protected]>
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
3be5c53 to
f21f96d
Compare
@fracado , thank you so much for your feedback and suggestions, I like them very much! |
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
|
Added fix for thumbnail size for grid view: 1e6fc7c: since the update to NC version 30 the thumbnails in grid view were too large. That was already fixed for new FA icons in apps/files, but probably was lost while update-rebase. So fixed it here. |
fracado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review OK
No description provided.