Skip to content

style(files_sharing): adjust footer position to avoid overlapping #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fracado merged 1 commit into from
Mar 10, 2025
Merged

style(files_sharing): adjust footer position to avoid overlapping #50

fracado merged 1 commit into from
Mar 10, 2025

Conversation

@fracado
Copy link
Contributor

@fracado fracado commented Mar 3, 2025 •
edited
Loading

  • position footer at the very bottom of the page to remove gap
  • adjust height of main content to avoid overlapping with footer
  • adjust bottom padding of upload content to avoid overlapping with footer (relevant at least on mobile screens)
  • adjust width of footer to avoid overlapping with scroll bar

@fracado fracado mentioned this pull request Mar 3, 2025
Merged
bromiesTM
bromiesTM approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@bromiesTM bromiesTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review ok if
you make it use the full width to avoid the short line next to the footer
image

@fracado
Copy link
Contributor Author

fracado commented Mar 4, 2025

review ok if you make it use the full width to avoid the short line next to the footer image

Ah... I see. I reduced the width to fix an overlap with the scroll bar on the right (seen when uploading many items). But this is worse, of course. I'll revert this.

@fracado fracado force-pushed the fb/dev/fix-share-footer branch from a207ddb to d919e34 Compare March 5, 2025 10:04
@fracado fracado requested a review from bromiesTM March 5, 2025 10:05
bromiesTM
bromiesTM reviewed Mar 6, 2025
View reviewed changes
@fracado fracado force-pushed the fb/dev/fix-share-footer branch from d919e34 to 39a2f12 Compare March 6, 2025 12:33
bromiesTM
bromiesTM reviewed Mar 6, 2025
View reviewed changes
Copy link
Contributor

@bromiesTM bromiesTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really sorry 🫣
accidentally found another issue with the share footer.
If you open a single image as share the preview image size causes the download button to slip behind the footer partially.
removing the padding-top from #imgframe helps

@fracado fracado force-pushed the fb/dev/fix-share-footer branch from 39a2f12 to d3e1bec Compare March 7, 2025 09:39
@fracado
Copy link
Contributor Author

fracado commented Mar 7, 2025 •
edited
Loading

Really sorry 🫣 accidentally found another issue with the share footer. If you open a single image as share the preview image size causes the download button to slip behind the footer partially. removing the padding-top from #imgframe helps

😅 Thank you for finding this! Fixed with reducing button top margin

@fracado fracado force-pushed the fb/dev/fix-share-footer branch from d3e1bec to a11ce5b Compare March 7, 2025 09:44
@fracado fracado merged commit a07dead into main Mar 10, 2025
4 of 11 checks passed
@fracado fracado deleted the fb/dev/fix-share-footer branch March 10, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bromiesTM bromiesTM bromiesTM approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fracado @bromiesTM